Issue 138443009: Mark weak fields of JSArrayBuffer and JSArrayBufferView as weak in heap snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138443009: Mark weak fields of JSArrayBuffer and JSArrayBufferView as weak in heap snapshot. (Closed)

Created:
6 years, 11 months ago by alph

Modified:
6 years, 11 months ago

Reviewers:
Dmitry Lomov (no reviews), ulan, yurys, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Mark weak fields of JSArrayBuffer and JSArrayBufferView as weak in heap snapshot. BUG=337144 LOG=N R=ulan@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18830

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	M	src/heap-snapshot-generator.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
	M	test/cctest/test-heap-profiler.cc	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

yurys

lgtm, But we need to automate process of discovering weak references to make sure all ...

6 years, 11 months ago (2014-01-24 13:12:20 UTC) #4

alph

6 years, 11 months ago (2014-01-24 15:10:45 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 manually as r18830 (presubmit successful).