Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 138443008: Don't hardcode GCC_VERSION for Xcode in standalone.gypi. (Closed)

Created:
6 years, 11 months ago by Jakob Kummerow
Modified:
6 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Don't hardcode GCC_VERSION for Xcode in standalone.gypi. This fixes standalone command-line Xcode compilation with Xcode 5.x. R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/standalone.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
Trybot success: http://build.chromium.org/p/tryserver.v8/builders/mac_rel/builds/55 PTAL.
6 years, 11 months ago (2014-01-23 15:33:17 UTC) #1
Michael Achenbach
lgtm - lets give it a bigger try
6 years, 11 months ago (2014-01-23 15:45:35 UTC) #2
Jakob Kummerow
6 years, 11 months ago (2014-01-23 15:55:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18785 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698