Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 138443002: Revert of Create our own blink_heap run_all_tests target to avoid piggy-backing on wtf's. (Closed)

Created:
6 years, 11 months ago by alph
Modified:
6 years, 11 months ago
CC:
blink-reviews, haraken, Mads Ager (chromium)
Visibility:
Public.

Description

Revert of Create our own blink_heap run_all_tests target to avoid piggy-backing on wtf's. (https://codereview.chromium.org/138133002/) Reason for revert: Broke compile. Original issue's description: > Create our own blink_heap run_all_tests target to avoid piggy-backing on wtf's. > > We used to use wtf's run_all_tests target to run out blink heap unittests. That causes a problem when we want to initialize our heap since we cannot call Heap::init/shutdown from wtf's RunAllTests since it cannot/should not depend on blink heap. > > R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, vegorov@chromium.org, zerny@chromium.org > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165073 TBR=ager@chromium.org,erik.corry@gmail.com,haraken@chromium.org,vegorov@chromium.org,zerny@chromium.org,wibling@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -117 lines) Patch
M Source/core/Init.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/heap/HeapTest.cpp View 12 chunks +110 lines, -17 lines 0 comments Download
D Source/heap/RunAllTests.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
M Source/heap/blink_heap_tests.gyp View 1 chunk +22 lines, -38 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
alph
Created Revert of Create our own blink_heap run_all_tests target to avoid piggy-backing on wtf's.
6 years, 11 months ago (2014-01-14 16:07:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/138443002/1
6 years, 11 months ago (2014-01-14 16:07:47 UTC) #2
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 16:08:16 UTC) #3
Message was sent while issue was closed.
Change committed as 165077

Powered by Google App Engine
This is Rietveld 408576698