Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1384423002: Separate policy indicator strings (Closed)

Created:
5 years, 2 months ago by stevenjb
Modified:
5 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Separate policy indicator strings This CL moves the policy indicator strings to a separate .cc file so that they can be included by any web UI that needs them (e.g. the extensions page). BUG=521791 Committed: https://crrev.com/bc1d700ff9f2cdb92e059d8d5b12f45b6216549d Cr-Commit-Position: refs/heads/master@{#352529}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase + update example extension name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -26 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/settings_strings.grdp View 1 chunk +0 lines, -5 lines 0 comments Download
A + chrome/browser/ui/webui/policy_indicator_localized_strings_provider.h View 1 chunk +6 lines, -6 lines 0 comments Download
A chrome/browser/ui/webui/policy_indicator_localized_strings_provider.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 3 chunks +3 lines, -15 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
stevenjb
5 years, 2 months ago (2015-10-06 00:26:40 UTC) #2
Dan Beam
lgtm https://codereview.chromium.org/1384423002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/1384423002/diff/1/chrome/app/generated_resources.grd#newcode10435 chrome/app/generated_resources.grd:10435: + This setting is controlled by extension <ph ...
5 years, 2 months ago (2015-10-06 01:22:29 UTC) #3
stevenjb
https://codereview.chromium.org/1384423002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/1384423002/diff/1/chrome/app/generated_resources.grd#newcode10435 chrome/app/generated_resources.grd:10435: + This setting is controlled by extension <ph name="NAME">$1<ex>Settings ...
5 years, 2 months ago (2015-10-06 01:42:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384423002/20001
5 years, 2 months ago (2015-10-06 01:43:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-06 03:35:45 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 03:36:29 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bc1d700ff9f2cdb92e059d8d5b12f45b6216549d
Cr-Commit-Position: refs/heads/master@{#352529}

Powered by Google App Engine
This is Rietveld 408576698