Issue 13844022: Remove code to support Objective-C bindings

Issue 13844022: Remove code to support Objective-C bindings (Closed)

Created:
7 years, 7 months ago by adamk

Modified:
7 years, 7 months ago

Reviewers:
eseidel

CC:
blink-reviews, abarth-chromium, eseidel, arv (Not doing code reviews), Mike West

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove code to support Objective-C bindings Several bits of core have extra method overloads or even separate methods that existed only to support WebKit's objc bindings. There's no need for this code to exist in Blink. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149373

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -111 lines)			Patch
M	Source/WebKit/chromium/src/WebDOMMessageEvent.cpp	View	1 chunk	+1 line, -1 line	2 comments	Download
M	Source/core/dom/Document.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	Source/core/dom/Entity.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/dom/MessageEvent.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/core/dom/MessageEvent.cpp	View	1 chunk	+0 lines, -26 lines	0 comments	Download
M	Source/core/dom/MessagePort.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/MessagePort.cpp	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	Source/core/dom/NodeFilter.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	Source/core/dom/NodeIterator.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/dom/TreeWalker.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	Source/core/dom/WheelEvent.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/page/DOMWindow.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/page/DOMWindow.cpp	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	Source/core/page/EventSource.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/workers/DedicatedWorkerContext.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/workers/DedicatedWorkerContext.cpp	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	Source/core/workers/Worker.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/workers/Worker.cpp	View	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/13844022/diff/1/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp File Source/WebKit/chromium/src/WebDOMMessageEvent.cpp (right): https://codereview.chromium.org/13844022/diff/1/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp#newcode62 Source/WebKit/chromium/src/WebDOMMessageEvent.cpp:62: return WebSerializedScriptValue(constUnwrap<MessageEvent>()->dataAsSerializedScriptValue()); I don't understand this change.

7 years, 7 months ago (2013-04-29 21:00:35 UTC) #2

adamk

https://codereview.chromium.org/13844022/diff/1/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp File Source/WebKit/chromium/src/WebDOMMessageEvent.cpp (right): https://codereview.chromium.org/13844022/diff/1/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp#newcode62 Source/WebKit/chromium/src/WebDOMMessageEvent.cpp:62: return WebSerializedScriptValue(constUnwrap<MessageEvent>()->dataAsSerializedScriptValue()); On 2013/04/29 21:00:35, Eric Seidel (Google) wrote: ...

7 years, 7 months ago (2013-04-29 21:09:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/13844022/1

7 years, 7 months ago (2013-04-29 21:17:44 UTC) #4

Message was sent while issue was closed.

Change committed as 149373

Expand Messages | Collapse Messages