Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1628)

Issue 13844011: GM: add self-test that sets --readPath to a nonexistent directory path (Closed)

Created:
7 years, 8 months ago by epoger
Modified:
7 years, 8 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

GM: add self-test that sets --readPath to a nonexistent directory path Committed: https://code.google.com/p/skia/source/detail?r=8664

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, --1 lines) Patch
A gm/tests/outputs/compared-against-nonexistent-dir/output-expected/command_line View 1 chunk +1 line, -0 lines 0 comments Download
A gm/tests/outputs/compared-against-nonexistent-dir/output-expected/return_value View 1 chunk +1 line, -0 lines 0 comments Download
A gm/tests/outputs/compared-against-nonexistent-dir/output-expected/stderr View 1 chunk +1 line, -0 lines 0 comments Download
A gm/tests/outputs/compared-against-nonexistent-dir/output-expected/stdout View 0 chunks +-1 lines, --1 lines 0 comments Download
M gm/tests/run.sh View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
epoger
7 years, 8 months ago (2013-04-12 18:25:25 UTC) #1
borenet
LGTM
7 years, 8 months ago (2013-04-12 18:43:47 UTC) #2
epoger
7 years, 8 months ago (2013-04-12 19:06:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r8664 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698