Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 13844006: MediaStream API: Moving Add/Remove track from WebMediaStreamCenterClient to WebMediaStream (Closed)

Created:
7 years, 8 months ago by Tommy Widenflycht
Modified:
7 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, abarth_chromum.org
Visibility:
Public.

Description

MediaStream API: Moving Add/Remove track from WebMediaStreamCenterClient to WebMediaStream Simple cleanup that makes the API cleaner. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148371

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -35 lines) Patch
M Source/Platform/chromium/public/WebMediaStream.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/Platform/chromium/public/WebMediaStreamCenterClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/chromium/support/WebMediaStream.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/WebCore/platform/mediastream/MediaStreamCenter.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/platform/mediastream/MediaStreamCenter.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/WebCore/platform/mediastream/MediaStreamDescriptor.h View 1 chunk +14 lines, -2 lines 0 comments Download
M Source/WebCore/platform/mediastream/chromium/MediaStreamCenterChromium.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/mediastream/chromium/MediaStreamCenterChromium.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/modules/mediastream/MediaStream.cpp View 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Tommy Widenflycht
7 years, 8 months ago (2013-04-12 13:19:30 UTC) #1
abarth-chromium
Looks great! LGTM By the way, we can remove most of this descriptor stuff now ...
7 years, 8 months ago (2013-04-12 16:42:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/13844006/1
7 years, 8 months ago (2013-04-15 07:49:35 UTC) #3
Tommy Widenflycht
7 years, 8 months ago (2013-04-15 11:29:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r148371 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698