base/trace_event/process_memory_totals_dump_provider.h - Issue 1384363002: [NOT TO COMMIT YET] Using proc/pid/status file contents to get process metrics in linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/process_memory_totals_dump_provider.h

Issue 1384363002: [NOT TO COMMIT YET] Using proc/pid/status file contents to get process metrics in linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@smaps_fscan

Patch Set: Change the api. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/process/process_metrics_unittest.cc ('k') | base/trace_event/process_memory_totals_dump_provider.cc » ('j') | base/trace_event/process_memory_totals_dump_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event/process_memory_totals_dump_provider.h

diff --git a/base/trace_event/process_memory_totals_dump_provider.h b/base/trace_event/process_memory_totals_dump_provider.h

index 66d4f9956dd5b9144f2352f55209a249e8742017..1ed511b30b07d97f5618b0448a43ceb4d2c8c869 100644

--- a/base/trace_event/process_memory_totals_dump_provider.h

+++ b/base/trace_event/process_memory_totals_dump_provider.h

@@ -5,6 +5,7 @@

#ifndef BASE_TRACE_EVENT_PROCESS_MEMORY_TOTALS_DUMP_PROVIDER_H_

#define BASE_TRACE_EVENT_PROCESS_MEMORY_TOTALS_DUMP_PROVIDER_H_

+#include "base/files/scoped_file.h"

#include "base/gtest_prod_util.h"

#include "base/memory/scoped_ptr.h"

#include "base/memory/singleton.h"

@@ -25,6 +26,9 @@ class BASE_EXPORT ProcessMemoryTotalsDumpProvider : public MemoryDumpProvider {

bool OnMemoryDump(const MemoryDumpArgs& args,

ProcessMemoryDump* pmd) override;

+ // proc/<pid>/status file. Used only in linux and andriod.

+ ScopedFILE proc_status_file;

private:

friend struct DefaultSingletonTraits<ProcessMemoryTotalsDumpProvider>;

FRIEND_TEST_ALL_PREFIXES(ProcessMemoryTotalsDumpProviderTest, DumpRSS);