Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1384343002: Call EnsureNSSHttpIOInit in the chimera build. (Closed)

Created:
5 years, 2 months ago by davidben
Modified:
5 years, 2 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call EnsureNSSHttpIOInit in the chimera build. Otherwise we end up using the default NSS client and not SystemURLRequestContext. This is a minimal fix to be merged onto release branches. A follow-up will revise this to be somewhat less error-prone. BUG=539520 TEST=Open about:net-internals on Linux or Chrome OS Visit https://incomplete-chain.badssl.com/ in a new tab The Events tab of about:net-internals should show a fetch for http://crt.comodoca.com/COMODORSADomainValidationSecureServerCA.crt Committed: https://crrev.com/a477a70ad63769c456ed87b78830e2ccbf75d583 Cr-Commit-Position: refs/heads/master@{#352536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M net/socket/ssl_client_socket_openssl.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
5 years, 2 months ago (2015-10-05 19:07:10 UTC) #2
Ryan Sleevi
lgtm
5 years, 2 months ago (2015-10-06 03:09:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384343002/1
5 years, 2 months ago (2015-10-06 03:10:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 04:39:10 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 04:39:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a477a70ad63769c456ed87b78830e2ccbf75d583
Cr-Commit-Position: refs/heads/master@{#352536}

Powered by Google App Engine
This is Rietveld 408576698