Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 138433003: Remove TreatNullAs=NullString for SVGElement.xmlbase (Closed)

Created:
6 years, 11 months ago by philipj_slow
Modified:
6 years, 11 months ago
CC:
blink-reviews, krit, arv+blink, f(malita), Inactive, pdr, Stephen Chennney, watchdog-blink-watchlist_google.com, rwlbuis
Visibility:
Public.

Description

Remove TreatNullAs=NullString for SVGElement.xmlbase http://www.w3.org/TR/SVG11/types.html#InterfaceSVGElement The test passes in Firefox Nightly, IE11 Release Preview and Opera 12.16. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165083

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
6 years, 11 months ago (2014-01-14 17:27:26 UTC) #1
arv (Not doing code reviews)
LGTM
6 years, 11 months ago (2014-01-14 17:31:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/138433003/1
6 years, 11 months ago (2014-01-14 17:44:08 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 18:01:25 UTC) #4
Message was sent while issue was closed.
Change committed as 165083

Powered by Google App Engine
This is Rietveld 408576698