Source/core/rendering/RenderMenuList.cpp - Issue 138433002: Add Autofill preview support for <select> input fields

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMenuList.cpp

Issue 138433002: Add Autofill preview support for <select> input fields (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Initialize m_suggestedIndex in constructor Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderMenuList.cpp

diff --git a/Source/core/rendering/RenderMenuList.cpp b/Source/core/rendering/RenderMenuList.cpp

index 5b28b71bb3d84b4cd73f0abdc16aae52d9144f0c..5d7457a8ccfe6d054a7483aa3c77dda0c9350eef 100644

--- a/Source/core/rendering/RenderMenuList.cpp

+++ b/Source/core/rendering/RenderMenuList.cpp

@@ -201,10 +201,14 @@ void RenderMenuList::updateFromElement()

m_optionsChanged = false;

}

- if (m_popupIsVisible)

+ if (m_popupIsVisible) {

m_popup->updateFromElement();

- else

- setTextFromOption(selectElement()->selectedIndex());

+ } else {

+ if (selectElement()->suggestedIndex() >= 0)

+ setTextFromOption(selectElement()->suggestedIndex());

+ else

+ setTextFromOption(selectElement()->selectedIndex());

+ }

}

void RenderMenuList::setTextFromOption(int optionIndex)

« no previous file with comments | « Source/core/rendering/RenderListBox.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »