Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Unified Diff: Source/web/WebFormControlElement.cpp

Issue 138433002: Add Autofill preview support for <select> input fields (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update code as per keishi's review comment. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebFormControlElement.cpp
diff --git a/Source/web/WebFormControlElement.cpp b/Source/web/WebFormControlElement.cpp
index 585260f9128cf504a3271050c653b73089137eba..3968d035eef3a6afa8ac74c540e737edcfacd43a 100644
--- a/Source/web/WebFormControlElement.cpp
+++ b/Source/web/WebFormControlElement.cpp
@@ -119,6 +119,8 @@ void WebFormControlElement::setSuggestedValue(const WebString& value)
unwrap<HTMLInputElement>()->setSuggestedValue(value);
if (m_private->hasTagName(HTMLNames::textareaTag))
unwrap<HTMLTextAreaElement>()->setSuggestedValue(value);
+ if (m_private->hasTagName(HTMLNames::selectTag))
+ unwrap<HTMLSelectElement>()->setSuggestedValue(value);
}
WebString WebFormControlElement::suggestedValue() const
@@ -127,6 +129,8 @@ WebString WebFormControlElement::suggestedValue() const
return constUnwrap<HTMLInputElement>()->suggestedValue();
if (m_private->hasTagName(HTMLNames::textareaTag))
return constUnwrap<HTMLTextAreaElement>()->suggestedValue();
+ if (m_private->hasTagName(HTMLNames::selectTag))
+ return constUnwrap<HTMLSelectElement>()->suggestedValue();
return WebString();
}

Powered by Google App Engine
This is Rietveld 408576698