Source/core/html/HTMLSelectElement.h - Issue 138433002: Add Autofill preview support for <select> input fields

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.h

Issue 138433002: Add Autofill preview support for <select> input fields (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update code as per keishi's review comment. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLSelectElement.h

diff --git a/Source/core/html/HTMLSelectElement.h b/Source/core/html/HTMLSelectElement.h

index 40b0e733cb13ee1564b94b0ce98e4e1e98a5caf2..179b83a9a9b46de847ee3a720b2a76267493c7c6 100644

--- a/Source/core/html/HTMLSelectElement.h

+++ b/Source/core/html/HTMLSelectElement.h

@@ -44,6 +44,8 @@ public:

int selectedIndex() const;

void setSelectedIndex(int);

+ int suggestedIndex() const;

+ void setSuggestedIndex(int);

void optionSelectedByUser(int index, bool dispatchChangeEvent, bool allowMultipleSelection = false);

@@ -67,6 +69,8 @@ public:

String value() const;

void setValue(const String&);

+ String suggestedValue() const;

+ void setSuggestedValue(const String&);

PassRefPtr<HTMLOptionsCollection> options();

PassRefPtr<HTMLCollection> selectedOptions();

@@ -204,6 +208,9 @@ private:

bool m_multiple;

bool m_activeSelectionState;

mutable bool m_shouldRecalcListItems;

+ String m_suggestedValue;

tkent 2014/03/14 00:06:41 Why m_suggestedValue is necessary? Isn't m_sugges

ziran.sun 2014/03/14 11:33:40 Done.

+ int m_suggestedIndex;

};

} // namespace

« no previous file with comments | « Source/core/css/html.css ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | Source/core/html/HTMLSelectElement.cpp » ('J')