Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1384323002: Pass yuvconstants to YUV conversions for neon 64 bit (Closed)

Created:
5 years, 2 months ago by fbarchard1
Modified:
5 years, 2 months ago
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Pass yuvconstants to YUV conversions for neon 64 bit SETUP provided by zhongwei.yao@linaro.org Previously the 64 bit Neon code had hard coded constants in the setup macro for YUV conversion, while 32 bit Neon code supported the yuvconstants parameter. This change accepts the constants passed to the YUV conversion row function, allowing different color spaces to be respected - naming JPEG and BT.709. As well as the existing BT.601. TBR=harryjin@google.com BUG=libyuv:472 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/013080f2d2153e6c5253573fa86a63e4b5843f71

Patch Set 1 #

Patch Set 2 : setup macros using structure #

Patch Set 3 : pass yuvconstants to YUVTORGB_SETUP #

Patch Set 4 : nv12 use setup parameters #

Patch Set 5 : remove Yvu struct for arm #

Patch Set 6 : aarch64 C version grab constants from aarch64 structure #

Patch Set 7 : nv12 pass parameters to yuv conversion macros #

Patch Set 8 : bump version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -60 lines) Patch
M README.chromium View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/row.h View 1 2 3 4 5 2 chunks +4 lines, -5 lines 0 comments Download
M include/libyuv/version.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M source/row_common.cc View 1 2 3 4 5 4 chunks +20 lines, -16 lines 0 comments Download
M source/row_neon64.cc View 1 2 3 4 5 6 18 chunks +68 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
fbarchard
nv21 now uses same matrix as nv12. tested the code compiles on ios aarch64, but ...
5 years, 2 months ago (2015-10-07 04:46:38 UTC) #4
fbarchard1
Committed patchset #8 (id:140001) manually as 013080f2d2153e6c5253573fa86a63e4b5843f71 (presubmit successful).
5 years, 2 months ago (2015-10-07 05:19:21 UTC) #5
harryjin
5 years, 2 months ago (2015-10-07 05:31:23 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698