Web MIDI: implement MIDIPort

Web MIDI: implement MIDIPort

This change implements MIDIPort.

BUG=163795
TEST=none
R=crogers@google.com

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149071

[Takashi Toyoshima, 2013-04-24 14:32:48]

Hi Chris.

Next, I'd try to land MIDIPort on which many interfaces depend.
Currently, IDL generator doesn't support readonly enum. But nbarth will fix to
support it very soon. I'd use DOMString instead of enum in this CL, but will be
replaced once nbarth land the fix.

Thanks.

[Chris Rogers, 2013-04-24 19:18:09]

lgtm with nits - I understand about the DOMString versus enum since we have the
same problem in Web Audio

https://codereview.chromium.org/13843021/diff/2001/Source/core/dom/EventTarget.h
File Source/core/dom/EventTarget.h (right):

https://codereview.chromium.org/13843021/diff/2001/Source/core/dom/EventTarge...
Source/core/dom/EventTarget.h:57: class MIDIPort;
nit: alphabetical order

https://codereview.chromium.org/13843021/diff/2001/Source/core/dom/EventTarge...
File Source/core/dom/EventTargetFactory.in (right):

https://codereview.chromium.org/13843021/diff/2001/Source/core/dom/EventTarge...
Source/core/dom/EventTargetFactory.in:18: MIDIPort
nit: most of the file is alphabetical order, so can put in proper order

https://codereview.chromium.org/13843021/diff/2001/Source/modules/webmidi/MID...
File Source/modules/webmidi/MIDIPort.idl (right):

https://codereview.chromium.org/13843021/diff/2001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDIPort.idl:45: //readonly attribute MIDIPortType type;
It's ok just to have the comment with bug number above - you can remove this
commented out line.

[Takashi Toyoshima, 2013-04-25 02:29:45]

https://codereview.chromium.org/13843021/diff/2001/Source/core/dom/EventTarge...
File Source/core/dom/EventTargetFactory.in (right):

https://codereview.chromium.org/13843021/diff/2001/Source/core/dom/EventTarge...
Source/core/dom/EventTargetFactory.in:18: MIDIPort
I thought this is unix sort command order, or ASCII code order. It mean that
lower case characters should follow upper case characters. So, I think MIDI <
Media < Midi. That's the reason why I place MIDIPort here.

But, Speech < SVG at line 35:36. That is not ASCII code order. What do you think
about this?

[Chris Rogers, 2013-04-25 02:55:58]

On 2013/04/25 02:29:45, Takashi Toyoshima (chromium) wrote:
>
https://codereview.chromium.org/13843021/diff/2001/Source/core/dom/EventTarge...
> File Source/core/dom/EventTargetFactory.in (right):
> 
>
https://codereview.chromium.org/13843021/diff/2001/Source/core/dom/EventTarge...
> Source/core/dom/EventTargetFactory.in:18: MIDIPort
> I thought this is unix sort command order, or ASCII code order. It mean that
> lower case characters should follow upper case characters. So, I think MIDI <
> Media < Midi. That's the reason why I place MIDIPort here.
> 
> But, Speech < SVG at line 35:36. That is not ASCII code order. What do you
think
> about this?

Ah you're right, never mind. unix sort should be right.  It's really just a
small nit anyway.

[Takashi Toyoshima, 2013-04-25 03:47:22]

https://codereview.chromium.org/13843021/diff/2001/Source/core/dom/EventTarge...
File Source/core/dom/EventTargetFactory.in (right):

https://codereview.chromium.org/13843021/diff/2001/Source/core/dom/EventTarge...
Source/core/dom/EventTargetFactory.in:18: MIDIPort
OK, I'll adopt unix order here.

https://codereview.chromium.org/13843021/diff/2001/Source/modules/webmidi/MID...
File Source/modules/webmidi/MIDIPort.idl (right):

https://codereview.chromium.org/13843021/diff/2001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDIPort.idl:45: //readonly attribute MIDIPortType type;
On 2013/04/24 19:18:09, Chris Rogers wrote:
> It's ok just to have the comment with bug number above - you can remove this
> commented out line.

Done.

[Takashi Toyoshima, 2013-04-25 03:59:57]

Committed patchset #4 manually as r149071 (presubmit successful).

[tkent, 2013-04-25 04:08:12]

https://codereview.chromium.org/13843021/diff/13001/Source/modules/webmidi/MI...
File Source/modules/webmidi/MIDIPort.cpp (right):

https://codereview.chromium.org/13843021/diff/13001/Source/modules/webmidi/MI...
Source/modules/webmidi/MIDIPort.cpp:32: 
This blank line is unnecessary.
http://dev.chromium.org/blink/coding-style#TOC-include-Statements

https://codereview.chromium.org/13843021/diff/13001/Source/modules/webmidi/MI...
Source/modules/webmidi/MIDIPort.cpp:64: return "input";
Please use ASCIILiteral("input")

https://codereview.chromium.org/13843021/diff/13001/Source/modules/webmidi/MI...
Source/modules/webmidi/MIDIPort.cpp:66: return "output";
Ditto.

https://codereview.chromium.org/13843021/diff/13001/Source/modules/webmidi/MI...
Source/modules/webmidi/MIDIPort.cpp:70: return "";
Use emptyString().

[Takashi Toyoshima, 2013-04-25 04:26:06]

Thank you Kent-san.
I'll make cleanup change soon.