Issue 13843016: Prepare to remove WebSecurityOrigin from IDB backend

Issue 13843016: Prepare to remove WebSecurityOrigin from IDB backend (Closed)

Created:
7 years, 8 months ago by alecflett

Modified:
7 years, 8 months ago

Reviewers:
jsbell, abarth-chromium

CC:
blink-reviews, jamesr, dgrogan, jsbell, abarth_chromum.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Prepare to remove WebSecurityOrigin from IDB backend The WebIDB backend doesn't need WebSecurityOrigin. This is part of the effort to wean IDB's backend off of the WebKit APIs. BUG=233361 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149053

Patch Set 1 #

Patch Set 2 : Fix missing frame #

Patch Set 3 : Use new API in proxy #

Patch Set 4 : Update to new #includes #

Total comments: 1

Patch Set 5 : remove extraneous SecurityOrigin #

Patch Set 6 : remove unused static #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -51 lines)			Patch
M	Source/WebKit/chromium/public/WebIDBFactory.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/WebKit/chromium/src/IDBFactoryBackendProxy.h	View	1 2 3 4	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp	View	1 2 3 4 5	1 chunk	+9 lines, -22 lines	0 comments	Download
M	Source/WebKit/chromium/src/WebIDBFactoryImpl.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/WebKit/chromium/src/WebIDBFactoryImpl.cpp	View		2 chunks	+21 lines, -3 lines	0 comments	Download
M	Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/indexeddb/IDBFactory.cpp	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/modules/indexeddb/IDBFactoryBackendImpl.h	View	1 2 3	2 chunks	+3 lines, -4 lines	0 comments	Download
M	Source/modules/indexeddb/IDBFactoryBackendImpl.cpp	View	1 2 3	5 chunks	+8 lines, -11 lines	0 comments	Download
M	Source/modules/indexeddb/IDBFactoryBackendInterface.h	View	1 2 3	2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

alecflett

This removes all the origin stuff from the factory. Part 1 of 3 Part 2 ...

7 years, 8 months ago (2013-04-24 03:34:45 UTC) #1

jsbell

lgtm... https://codereview.chromium.org/13843016/diff/7001/Source/WebKit/chromium/src/IDBFactoryBackendProxy.h File Source/WebKit/chromium/src/IDBFactoryBackendProxy.h (right): https://codereview.chromium.org/13843016/diff/7001/Source/WebKit/chromium/src/IDBFactoryBackendProxy.h#newcode37 Source/WebKit/chromium/src/IDBFactoryBackendProxy.h:37: class SecurityOrigin; This seems extraneous.

7 years, 8 months ago (2013-04-24 21:25:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/13843016/12001

7 years, 8 months ago (2013-04-24 21:49:52 UTC) #4

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 8 months ago (2013-04-24 22:09:07 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/13843016/10002

7 years, 8 months ago (2013-04-24 22:25:44 UTC) #6

commit-bot: I haz the power

Retried try job too often on linux_layout_rel for step(s) test_shell_tests, webkit_lint, webkit_tests, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=5299

7 years, 8 months ago (2013-04-24 22:41:13 UTC) #7

alecflett

7 years, 8 months ago (2013-04-24 23:13:32 UTC) #8

Message was sent while issue was closed.

Committed patchset #6 manually as r149053 (presubmit successful).

Expand Messages | Collapse Messages