Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: sdk/lib/_internal/pub/test/real_version_test.dart

Issue 13843013: Make real_version_test scheduled. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Bug fixes. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/test/real_version_test.dart
diff --git a/sdk/lib/_internal/pub/test/real_version_test.dart b/sdk/lib/_internal/pub/test/real_version_test.dart
index e42fedcf2ae1863cc8c3f24a37629429a8a2269f..b87a324d4070212ed4196b26138aae8cb0a73e31 100644
--- a/sdk/lib/_internal/pub/test/real_version_test.dart
+++ b/sdk/lib/_internal/pub/test/real_version_test.dart
@@ -7,7 +7,8 @@ library pub_tests;
import 'dart:io';
import 'package:pathos/path.dart' as path;
-import 'package:unittest/unittest.dart';
+import 'package:scheduled_test/scheduled_process.dart';
+import 'package:scheduled_test/scheduled_test.dart';
import 'test_pub.dart';
main() {
@@ -25,15 +26,14 @@ main() {
// Note that this test expects to be invoked from a Dart executable that is
// in the built SDK's "bin" directory. Note also that this invokes pub from
// the built SDK directory, and not the live pub code directly in the repo.
- test('parse the real SDK "version" file', () {
+ integration('parse the real SDK "version" file', () {
// Get the path to the pub binary in the SDK.
var dartPath = new Options().executable;
var pubPath = path.join(path.dirname(dartPath), "pub");
if (Platform.operatingSystem == "windows") pubPath = '$pubPath.bat';
- Process.run(pubPath, ['version']).then(expectAsync1((result) {
- expect(result.stdout, startsWith("Pub"));
- expect(result.exitCode, equals(0));
- }));
+ var pub = new ScheduledProcess.start(pubPath, ['version']);
+ expect(pub.nextLine(), completion(startsWith("Pub")));
+ pub.shouldExit(0);
});
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698