Make git-cl accepts multiple --reviewers and --cc arguments.

git_cl.py

Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 16a6e0c402523988ed52ffdcde792fed340158c0..8c6f8b39f3955206e3544d12f810b48c834468ea 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -1106,8 +1106,8 @@ def GerritUpload(options, args, cl):
   if CHANGE_ID not in log_desc:
     AddChangeIdToCommitMessage(options, args)
   if options.reviewers:
-    log_desc += '\nR=' + options.reviewers
-  change_desc = ChangeDescription(log_desc, options.reviewers)
+    log_desc += '\nR=' + ','.join(options.reviewers)
+  change_desc = ChangeDescription(log_desc, ','.join(options.reviewers))

[Dirk Pranke, 2013/04/10 19:55:46]

Nit: ', ' (with a space) might be more readable?

[M-A Ruel, 2013/04/10 20:32:07]

Done but it had implications, ptal.

   change_desc.ParseDescription()
   if change_desc.IsEmpty():
     print "Description is empty; aborting."
@@ -1116,7 +1116,7 @@ def GerritUpload(options, args, cl):
   receive_options = []
   cc = cl.GetCCList().split(',')
   if options.cc:
-    cc += options.cc.split(',')
+    cc.extend(options.cc)
   cc = filter(None, cc)
   if cc:
     receive_options += ['--cc=' + email for email in cc]
@@ -1159,7 +1159,7 @@ def RietveldUpload(options, args, cl):
     if options.title:
       upload_args.extend(['--title', options.title])
     message = options.title or options.message or CreateDescriptionFromLog(args)
-    change_desc = ChangeDescription(message, options.reviewers)
+    change_desc = ChangeDescription(message, ','.join(options.reviewers))
     if not options.force:
       change_desc.Prompt()
     change_desc.ParseDescription()
@@ -1175,7 +1175,7 @@ def RietveldUpload(options, args, cl):
       if not change_desc.reviewers:
         DieWithError("Must specify reviewers to send email.")
       upload_args.append('--send_mail')
-    cc = ','.join(filter(None, (cl.GetCCList(), options.cc)))
+    cc = ','.join(filter(None, (cl.GetCCList(), ','.join(options.cc))))
     if cc:
       upload_args.extend(['--cc', cc])
 
@@ -1228,6 +1228,15 @@ def RietveldUpload(options, args, cl):
   return 0
 
 
+def cleanup_list(l):
+  """Fixes a list so that comma separated items are put as individual items.
+
+  So that "--reviewers joe@c,john@c --reviewers joa@c" results in
+  options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
+  """
+  return sorted(filter(None, sum((i.split(',') for i in l), [])))
+
+
 @usage('[args to "git diff"]')
 def CMDupload(parser, args):
   """upload the current changelist to codereview"""
@@ -1238,8 +1247,10 @@ def CMDupload(parser, args):
   parser.add_option('-m', dest='message', help='message for patchset')
   parser.add_option('-t', dest='title', help='title for patchset')
   parser.add_option('-r', '--reviewers',
+                    action='append', default=[],
                     help='reviewer email addresses')
   parser.add_option('--cc',
+                    action='append', default=[],
                     help='cc email addresses')
   parser.add_option('-s', '--send-mail', action='store_true',
                     help='send email to reviewer immediately')
@@ -1268,6 +1279,9 @@ def CMDupload(parser, args):
   if is_dirty_git_tree('upload'):
     return 1
 
+  options.reviewers = cleanup_list(options.reviewers)
+  options.cc = cleanup_list(options.cc)
+
   cl = Changelist()
   if args:
     # TODO(ukai): is it ok for gerrit case?
@@ -1291,7 +1305,7 @@ def CMDupload(parser, args):
     if not hook_results.should_continue():
       return 1
     if not options.reviewers and hook_results.reviewers:
-      options.reviewers = hook_results.reviewers
+      options.reviewers = hook_results.reviewers.split(',')
 
   if cl.GetIssue():
     latest_patchset = cl.GetMostRecentPatchset(cl.GetIssue())