Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1384293002: Split http_proxy_test into two tests, with failing tests in a new file. (Closed)

Created:
5 years, 2 months ago by Bill Hesse
Modified:
5 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split http_proxy_test into two tests, with failing tests in a new file. BUG= R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/291ae520a9e9f52cfd766387575bd0ead2aafea4

Patch Set 1 #

Patch Set 2 : #Add issue number to status file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -541 lines) Patch
A + tests/standalone/io/http_proxy_advanced_test.dart View 3 chunks +5 lines, -194 lines 0 comments Download
M tests/standalone/io/http_proxy_test.dart View 2 chunks +0 lines, -347 lines 0 comments Download
M tests/standalone/standalone.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
5 years, 2 months ago (2015-10-05 14:07:00 UTC) #2
Søren Gjesse
lgtm
5 years, 2 months ago (2015-10-05 14:12:06 UTC) #3
Bill Hesse
5 years, 2 months ago (2015-10-05 14:33:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
291ae520a9e9f52cfd766387575bd0ead2aafea4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698