Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: chrome/browser/ui/cocoa/login_prompt_cocoa.mm

Issue 1384283003: Do not involve PasswordManagerDriver in filling HTTP-auth forms; also check realm (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Complete with new tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/login_prompt_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/login_prompt_cocoa.mm b/chrome/browser/ui/cocoa/login_prompt_cocoa.mm
index c2a6a8ea4cdb8dcacc5b6f8bb5574e31fa466f7a..2bba75fddbd8aeca7190dc7a8c952bf5388501c0 100644
--- a/chrome/browser/ui/cocoa/login_prompt_cocoa.mm
+++ b/chrome/browser/ui/cocoa/login_prompt_cocoa.mm
@@ -41,8 +41,9 @@ class LoginHandlerMac : public LoginHandler,
}
// LoginModelObserver implementation.
- void OnAutofillDataAvailable(const base::string16& username,
- const base::string16& password) override {
+ void OnAutofillDataAvailableInternal(
+ const base::string16& username,
+ const base::string16& password) override {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
[sheet_controller_ autofillLogin:base::SysUTF16ToNSString(username)
@@ -51,14 +52,17 @@ class LoginHandlerMac : public LoginHandler,
void OnLoginModelDestroying() override {}
// LoginHandler:
- void BuildViewForPasswordManager(password_manager::PasswordManager* manager,
- const base::string16& explanation) override {
+ void BuildViewForPasswordManager(
+ password_manager::PasswordManager* manager,
+ const base::string16& explanation,
+ const autofill::PasswordForm* observed_form) override {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
+ DCHECK_EQ(manager == nullptr, observed_form == nullptr);
sheet_controller_.reset(
[[LoginHandlerSheet alloc] initWithLoginHandler:this]);
- SetModel(manager);
+ SetModel(manager, observed_form);
[sheet_controller_ setExplanation:base::SysUTF16ToNSString(explanation)];
@@ -88,7 +92,7 @@ class LoginHandlerMac : public LoginHandler,
// Overridden from ConstrainedWindowMacDelegate:
void OnConstrainedWindowClosed(ConstrainedWindowMac* window) override {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- SetModel(NULL);
+ SetModel(nullptr, nullptr);
ReleaseSoon();
constrained_window_.reset();

Powered by Google App Engine
This is Rietveld 408576698