Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3538)

Unified Diff: chrome/browser/ui/views/login_view.h

Issue 1384283003: Do not involve PasswordManagerDriver in filling HTTP-auth forms; also check realm (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Mac Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/login_view.h
diff --git a/chrome/browser/ui/views/login_view.h b/chrome/browser/ui/views/login_view.h
index eab866d915b43feb3d8fb3b938a1a20cfc6872e7..b2cb06fd57ae5d892056e450bc47703ddaff2d64 100644
--- a/chrome/browser/ui/views/login_view.h
+++ b/chrome/browser/ui/views/login_view.h
@@ -6,6 +6,8 @@
#define CHROME_BROWSER_UI_VIEWS_LOGIN_VIEW_H_
#include "base/compiler_specific.h"
+#include "chrome/browser/ui/login/login_prompt.h"
+#include "components/autofill/core/common/password_form.h"
#include "components/password_manager/core/browser/login_model.h"
#include "ui/views/view.h"
@@ -19,10 +21,11 @@ class Textfield;
class LoginView : public views::View,
public password_manager::LoginModelObserver {
public:
- // |model| is observed for the entire lifetime of the LoginView.
- // Therefore |model| should not be destroyed before the LoginView object.
+ // |login_model_data->model| is observed for the entire lifetime of the
+ // LoginView. Therefore |login_model_data->model| should not be destroyed
+ // before the LoginView object. |login_model_data| may be null.
LoginView(const base::string16& explanation,
- password_manager::LoginModel* model);
+ LoginHandler::LoginModelData* login_model_data);
~LoginView() override;
// Access the data in the username/password text fields.
@@ -30,8 +33,8 @@ class LoginView : public views::View,
const base::string16& GetPassword() const;
// password_manager::LoginModelObserver:
- void OnAutofillDataAvailable(const base::string16& username,
- const base::string16& password) override;
+ void OnAutofillDataAvailableInternal(const base::string16& username,
+ const base::string16& password) override;
void OnLoginModelDestroying() override;
// Used by LoginHandlerWin to set the initial focus.

Powered by Google App Engine
This is Rietveld 408576698