WebRTC: Bot for autorolling WebRTC+libjingle in Chromium DEPS.

scripts/slave/recipes/webrtc/auto_roll_chromium_deps.py

Index: scripts/slave/recipes/webrtc/auto_roll_chromium_deps.py
diff --git a/scripts/slave/recipes/v8/auto_roll_deps.py b/scripts/slave/recipes/webrtc/auto_roll_chromium_deps.py
similarity index 67%
copy from scripts/slave/recipes/v8/auto_roll_deps.py
copy to scripts/slave/recipes/webrtc/auto_roll_chromium_deps.py
index 092466142c873adcc073f8b38aff063fa2ccd0e3..0b6eb738b95cded0e28f99ecce6b843b4fa07e9d 100644
--- a/scripts/slave/recipes/v8/auto_roll_deps.py
+++ b/scripts/slave/recipes/webrtc/auto_roll_chromium_deps.py
@@ -1,4 +1,4 @@
-# Copyright 2014 The Chromium Authors. All rights reserved.
+# Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
@@ -18,7 +18,7 @@ DEPS = [
 
 def ContainsChromiumRoll(changes):
   for change in changes:
-    if change['subject'].startswith('Update V8 to'):
+    if change['subject'].startswith('Roll WebRTC '):
       return True
   return False
 
@@ -26,13 +26,12 @@ def ContainsChromiumRoll(changes):
 def RunSteps(api):
   api.chromium.cleanup_temp()
   api.gclient.set_config('chromium')
-  api.gclient.apply_config('v8_bleeding_edge_git')

[kjellander_chromium, 2015/10/05 19:35:47]

Our script at
https://code.google.com/p/chromium/codesearch#chromium/src/tools/roll_webrtc.py
ensures the directories to run roll-dep-svn in are up to date using 'git fetch
origin'.

 
   step_result = api.python(
       'check roll status',
       api.path['build'].join('scripts', 'tools', 'runit.py'),
       [api.path['build'].join('scripts', 'tools', 'pycurl.py'),
-       'https://v8-roll.appspot.com/status'],
+       'https://webrtc-roll.appspot.com/status'],
       stdout=api.raw_io.output(),
       step_test_data=lambda: api.raw_io.test_api.stream_output(
           '1', stream='stdout')
@@ -46,7 +45,7 @@ def RunSteps(api):
 
   params = {
     'closed': 3,
-    'owner': 'v8-autoroll@chromium.org',
+    'owner': 'webrtc-autoroll@chromium.org',

[Michael Achenbach, 2015/10/06 09:31:55]

You have an account now?

[kjellander_chromium, 2015/10/06 09:58:09]

No, not yet. I might try this with my own account while waiting for that one.

[kjellander_chromium, 2015/10/26 08:40:29]

Now I have an account (crbug.com/539527).

[Michael Achenbach, 2015/10/26 08:54:38]

Acknowledged. FYI: You might need to log on to the bot once and log in to
rietveld with this account so that credentials are stored.

You might also want to add a git config for that account on the bot. Otherwise
your CL author might end up being called chrome-bot.

     'limit': 30,
     'format': 'json',
   }
@@ -73,31 +72,24 @@ def RunSteps(api):
 
   api.python(
       'roll deps',
-      api.path['checkout'].join(
-          'v8', 'tools', 'release', 'auto_roll.py'),
-      ['--chromium', api.path['checkout'],
-       '--author', 'v8-autoroll@chromium.org',
-       '--reviewer',
-       'hablich@chromium.org,machenbach@chromium.org,'
-       'yangguo@chromium.org,vogelheim@chromium.org',
-       '--roll',
-       '--work-dir', api.path['slave_build'].join('workdir')],
-      cwd=api.path['checkout'].join('v8'),
-    )
+      api.path['checkout'].join('tools', 'roll_webrtc.py'),
+      ['--wait-for-trybots', '--close-previous-roll', '--verbose'],
+      cwd=api.path['checkout'],

[Michael Achenbach, 2015/10/06 09:31:55]

Sure this works? This is from a chromium checkout.

[kjellander_chromium, 2015/10/06 09:58:09]

Yeah, we moved the script from WebRTC into Chromium a while back:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/roll_webrtc.py

I'm not entirely sure about the --wait-for-trybots thing since I don't think
anyone is using it but I wrote it with a bot like this in mind a while back, so
I'll give it a try. With that the build would go on until the CL is landed
instead of checking back over and over (resulting in many no-op builds, which
makes the overview harder to read).

[kjellander_chromium, 2015/10/26 08:40:29]

It's worth mentioning that this will wait for max 1 hour, and that will output
to stdio every 30 seconds so the build step shouldn't die. I might take this
away if it doesn't work but I like the idea about having less no-op builds that
do nothing, which is why I wanted to at least give it a try.

[Michael Achenbach, 2015/10/26 08:54:38]

Acknowledged.

+  )
 
 
 def GenTests(api):
-  yield api.test('standard') + api.properties.generic(
-      mastername='client.v8.fyi')
+  yield (api.test('standard') +
+      api.properties.generic(mastername='client.webrtc.fyi')
+  )
   yield (api.test('rolling_deactivated') +
-      api.properties.generic(mastername='client.v8') +
+      api.properties.generic(mastername='client.webrtc.fyi') +
       api.override_step_data(
           'check roll status', api.raw_io.stream_output('0', stream='stdout'))
-    )
+  )
   yield (api.test('active_roll') +
-      api.properties.generic(mastername='client.v8') +
+      api.properties.generic(mastername='client.webrtc.fyi') +
       api.override_step_data(
           'check active roll', api.raw_io.output(
-              '{"results": [{"subject": "Update V8 to foo"}]}'))
-    )
-
+              '{"results": [{"subject": "Roll WebRTC to 123"}]}'))
+  )