Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: mojo/tools/get_test_list.py

Issue 1384243002: Adds the ability to run pure Go unit tests in the Mojo test suite. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Further code review comment responses. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/tools/get_test_list.py
diff --git a/mojo/tools/get_test_list.py b/mojo/tools/get_test_list.py
index c59602c10244b174054ca4e0120d7a7db2ceaa19..74f820982a632da5bfd968fbf22dd6e13deff46f 100755
--- a/mojo/tools/get_test_list.py
+++ b/mojo/tools/get_test_list.py
@@ -117,9 +117,24 @@ def GetTestList(config, verbose_count=0):
if (target_os == Config.OS_LINUX and
config.sanitizer != Config.SANITIZER_ASAN and
ShouldRunTest(Config.TEST_TYPE_DEFAULT, Config.TEST_TYPE_UNIT, "go")):
- AddEntry("Go unit tests",
+ # Go system tests:
+ AddEntry("Go system tests",
[os.path.join(build_dir, "obj", "mojo", "go", "system_test")])
+ # Pure Go unit tests:
+ if "go_build_tool" in config.values:
+ go_tool = config.values["go_build_tool"]
+ else:
+ # Note(rudominer) This branch is necessary for when this script is
+ # run on the bots. In that case the config.values dictionary is built in
+ # the bot's recipe script and does not contain a value for
+ # "go_build_tool." Consider adding that value there instead.
+ go_tool = os.path.join(Paths().src_root, "third_party", "go", "tool",
viettrungluu 2015/10/06 21:06:28 In particular, if the go_build_tool directory shou
rudominer 2015/10/09 18:30:30 Done.
+ "linux_amd64", "bin", "go")
+ AddEntry("Go unit tests",
+ ["python", os.path.join("mojo", "tools", "run_pure_go_tests.py"),
+ go_tool, os.path.join("mojo", "tools", "data", "gotests")])
+
# Python unit tests:
if ShouldRunTest(Config.TEST_TYPE_DEFAULT, Config.TEST_TYPE_UNIT, "python"):
AddEntry("Python unit tests",

Powered by Google App Engine
This is Rietveld 408576698