Adds the ability to run pure Go unit tests in the Mojo test suite.

mojo/tools/get_test_list.py

Index: mojo/tools/get_test_list.py
diff --git a/mojo/tools/get_test_list.py b/mojo/tools/get_test_list.py
index c59602c10244b174054ca4e0120d7a7db2ceaa19..312cd012ef68e8ca39482a471b7d26069f09b785 100755
--- a/mojo/tools/get_test_list.py
+++ b/mojo/tools/get_test_list.py
@@ -117,9 +117,21 @@ def GetTestList(config, verbose_count=0):
   if (target_os == Config.OS_LINUX and
       config.sanitizer != Config.SANITIZER_ASAN and
       ShouldRunTest(Config.TEST_TYPE_DEFAULT, Config.TEST_TYPE_UNIT, "go")):
-    AddEntry("Go unit tests",
+
+    # Go system tests

[ppi, 2015/10/05 21:49:58]

Please end comment with ":" to match the others.

[rudominer, 2015/10/05 23:08:12]

Done.

+    AddEntry("Go system tests",
              [os.path.join(build_dir, "obj", "mojo", "go", "system_test")])
 
+    # Pure Go unit tests

[ppi, 2015/10/05 21:49:58]

Please end with ":".

[rudominer, 2015/10/05 23:08:12]

Done.

+    if 'go_build_tool' in config.values:

[viettrungluu, 2015/10/05 23:10:38]

Apparently, in this file, we prefer double quotes.

[rudominer, 2015/10/06 00:29:10]

Done.

+      go_tool = config.values['go_build_tool']
+    else:
+      go_tool = os.path.join(Paths().src_root, 'third_party', 'go', 'tool',

[viettrungluu, 2015/10/05 23:10:38]

Should this path ever be taken?

[rudominer, 2015/10/06 00:29:10]

The reason I added this is that on the try bots this function is not invoked via
"mojob.py test" but rather this script's main is invoked from the command line
and a json file is parsed in order to generate the config.values dictionary and
in that case it appears that the go_build_tool property is not set.

If you would prefer I could instead modify the json file so that the
go_build_tool property is there. That will require me to figure out where this
json file is.

[viettrungluu, 2015/10/06 01:46:29]

That sounds like the right thing to do.

[rudominer, 2015/10/06 20:28:53]

I discovered that the json file being consumed is generated by the function
_GetTestConfig() in the bot recipe file which is located in the chrome
infrastructure repo here:
https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave....
Looking at that method it is not clear to me that it is the right place to put
the path to the go binary. There is not other similar kinds of config data
there. Also it seems wrong to me to put a path to something within the mojo repo
in a file located in a different repo. For now I am leaving this as is and
adding a note. At any rate adding the data to the recipe file would have to be
done in a later CL.

[viettrungluu, 2015/10/06 21:03:44]

Then the question is why it's in the config at all, rather than being derived
from something in the config (which should be done in a common location).
You could add it now, with no harm.

[rudominer, 2015/10/09 18:30:30]

Took your later suggestion and am now using paths.

+        'linux_amd64', 'bin', 'go')
+    AddEntry("Pure go unit tests",

[ppi, 2015/10/05 21:49:58]

I'd just say "Go unit tests", as we have "Python unit tests" in the same spirit.

[rudominer, 2015/10/05 23:08:12]

Done. Note that I left the word "Pure" in the comment on line 125
because on line 116 the label "Go unit tests" is being used so
I liked the label "Pure Go unit tests" to make it clear this is a sub-category.

+            ["python", os.path.join("mojo", "tools", "run_pure_go_tests.py"),
+             "--go_tool=" + go_tool])
+
   # Python unit tests:
   if ShouldRunTest(Config.TEST_TYPE_DEFAULT, Config.TEST_TYPE_UNIT, "python"):
     AddEntry("Python unit tests",