Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc

Issue 1384233003: Improve usefulness of webglcontextcreationerror statusMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc
diff --git a/components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc b/components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc
index b9efa5e210612848094cbd35822c275be274485b..878e37aed522a3202bbc59542f087a1f0a7521ca 100644
--- a/components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc
+++ b/components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc
@@ -25,14 +25,15 @@ WebGraphicsContext3DCommandBufferImpl::CreateOffscreenContext(
const GURL& active_url,
const blink::WebGraphicsContext3D::Attributes& attributes,
blink::WebGraphicsContext3D* share_context,
- blink::WebGLInfo* gl_info) {
+ blink::WebGraphicsContext3D::WebGraphicsInfo* gl_info) {
const mus::mojom::GpuInfo* gpu_info = global_state->GetGpuInfo();
- gl_info->vendorId = gpu_info->vendor_id;
- gl_info->deviceId = gpu_info->device_id;
- gl_info->vendorInfo = gpu_info->vendor_info.To<blink::WebString>();
- gl_info->rendererInfo = gpu_info->renderer_info.To<blink::WebString>();
- gl_info->driverVersion = gpu_info->driver_version.To<blink::WebString>();
-
+ if (gl_info) {
+ gl_info->vendorId = gpu_info->vendor_id;
+ gl_info->deviceId = gpu_info->device_id;
+ gl_info->vendorInfo = gpu_info->vendor_info.To<blink::WebString>();
+ gl_info->rendererInfo = gpu_info->renderer_info.To<blink::WebString>();
+ gl_info->driverVersion = gpu_info->driver_version.To<blink::WebString>();
+ }
mojo::URLRequestPtr request(mojo::URLRequest::New());
request->url = mojo::String::From("mojo:mus");
mus::mojom::GpuPtr gpu_service;

Powered by Google App Engine
This is Rietveld 408576698