components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc - Issue 1384233003: Improve usefulness of webglcontextcreationerror statusMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc

Issue 1384233003: Improve usefulness of webglcontextcreationerror statusMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/html_viewer/blink_platform_impl.cc ('K') | « components/html_viewer/web_graphics_context_3d_command_buffer_impl.h ('k') | content/renderer/renderer_blink_platform_impl.h » ('j') | content/renderer/renderer_blink_platform_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc

diff --git a/components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc b/components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc

index f9e4c5bc600c1c05b97e2de033ecb120614229e5..55e216b0760cf64fad92c41b9bdb06e07d33be34 100644

--- a/components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc

+++ b/components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc

@@ -25,13 +25,13 @@ WebGraphicsContext3DCommandBufferImpl::CreateOffscreenContext(

const GURL& active_url,

const blink::WebGraphicsContext3D::Attributes& attributes,

blink::WebGraphicsContext3D* share_context,

- blink::WebGLInfo* gl_info) {

+ blink::WebGraphicsContext3D::WebGraphicsInfo& gl_info) {

const mojo::GpuInfo* gpu_info = global_state->GetGpuInfo();

- gl_info->vendorId = gpu_info->vendor_id;

- gl_info->deviceId = gpu_info->device_id;

- gl_info->vendorInfo = gpu_info->vendor_info.To<blink::WebString>();

- gl_info->rendererInfo = gpu_info->renderer_info.To<blink::WebString>();

- gl_info->driverVersion = gpu_info->driver_version.To<blink::WebString>();

+ gl_info.vendorId = gpu_info->vendor_id;

+ gl_info.deviceId = gpu_info->device_id;

+ gl_info.vendorInfo = gpu_info->vendor_info.To<blink::WebString>();

+ gl_info.rendererInfo = gpu_info->renderer_info.To<blink::WebString>();

+ gl_info.driverVersion = gpu_info->driver_version.To<blink::WebString>();

mojo::URLRequestPtr request(mojo::URLRequest::New());

request->url = mojo::String::From("mojo:mus");