content/renderer/renderer_blink_platform_impl.cc - Issue 1384233003: Improve usefulness of webglcontextcreationerror statusMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/renderer_blink_platform_impl.cc

Issue 1384233003: Improve usefulness of webglcontextcreationerror statusMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/renderer_blink_platform_impl.cc

diff --git a/content/renderer/renderer_blink_platform_impl.cc b/content/renderer/renderer_blink_platform_impl.cc

index 2203239669483cd9a2c1dde060c1e9fe7ed1f549..7746091017bd68d4b2ee80b7273c09d3e383b449 100644

--- a/content/renderer/renderer_blink_platform_impl.cc

+++ b/content/renderer/renderer_blink_platform_impl.cc

@@ -984,8 +984,10 @@ RendererBlinkPlatformImpl::createOffscreenGraphicsContext3D(

blink::WebString::fromUTF8(gpu_info.gl_renderer));

gl_info->driverVersion.assign(

blink::WebString::fromUTF8(gpu_info.driver_version));

- gl_info->vendorId = gpu_info.gpu.vendor_id;

- gl_info->deviceId = gpu_info.gpu.device_id;

+ gl_info->vendorId.assign(blink::WebString::fromUTF8(

+ base::StringPrintf("0x%04x", gpu_info.gpu.vendor_id)));

+ gl_info->deviceId.assign(blink::WebString::fromUTF8(

+ base::StringPrintf("0x%04x", gpu_info.gpu.device_id)));

break;

case gpu::kCollectInfoFatalFailure:

case gpu::kCollectInfoNone: