Improve usefulness of webglcontextcreationerror statusMessage

content/shell/app/shell_main_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/app/shell_main_delegate.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/cpu.h"
 #include "base/files/file.h"
@@ skipping 140 matching lines @@
     EnableBrowserLayoutTestMode();
 
     command_line.AppendSwitch(switches::kProcessPerTab);
     command_line.AppendSwitch(switches::kEnableLogging);
     command_line.AppendSwitch(switches::kAllowFileAccessFromFiles);
     // only default to osmesa if the flag isn't already specified.
     if (!command_line.HasSwitch(switches::kUseGL)) {
       command_line.AppendSwitchASCII(switches::kUseGL,
                                      gfx::kGLImplementationOSMesaName);
     }
-    command_line.AppendSwitch(switches::kSkipGpuDataLoading);

[Zhenyao Mo, 2015/10/16 18:46:11]

Note that removing this may slightly slows down tests that run on content shell,
say blink layout tests.

[Ken Russell (switch to Gerrit), 2015/10/16 21:44:13]

Will it have any other side-effects? Could it break tests that run on virtual
machines?

@sivag, is this change absolutely necessary? If not please take it out.

[sivag, 2015/10/19 16:19:23]

I removed this change.
If the id is null, i am appending the fake id to pass this in case of tests.

[sivag, 2015/10/19 16:19:23]

Done.

     command_line.AppendSwitchASCII(switches::kTouchEvents,
                                    switches::kTouchEventsEnabled);
     command_line.AppendSwitchASCII(switches::kForceDeviceScaleFactor, "1.0");
 #if defined(OS_ANDROID)
     command_line.AppendSwitch(
         switches::kDisableGestureRequirementForMediaPlayback);
 #endif
 
     if (!command_line.HasSwitch(switches::kStableReleaseMode)) {
       command_line.AppendSwitch(
@@ skipping 173 matching lines @@
 
   return renderer_client_.get();
 }
 
 ContentUtilityClient* ShellMainDelegate::CreateContentUtilityClient() {
   utility_client_.reset(new ShellContentUtilityClient);
   return utility_client_.get();
 }
 
 }  // namespace content