Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1384233002: Reland: [Oilpan] Move MediaStream{Source|Component|Descriptor} to Oilpan heap (Closed)

Created:
5 years, 2 months ago by peria
Modified:
5 years, 2 months ago
CC:
asanka, benjhayden+dwatch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, philipj_slow, Raymond Toy, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Revert of [Oilpan] Move MediaStream{Source|Component|Descriptor} to Oilpan heap" https://codereview.chromium.org/1363143003/ We think the tests that the original CL failed need to run more GCs to collect all objects. So we expect https://codereview.chromium.org/1383803003/ fixes the issue and we can land this CL again. BUG=496535 Committed: https://crrev.com/05c95a5912f97f877aa75bbd55581778ba7044d6 Cr-Commit-Position: refs/heads/master@{#352507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -141 lines) Patch
M third_party/WebKit/Source/modules/mediastream/MediaStream.h View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.cpp View 6 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamRegistry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 4 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaRequest.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaStream.cpp View 2 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaStreamTrack.cpp View 3 chunks +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.h View 4 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.cpp View 2 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.h View 4 chunks +17 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.cpp View 5 chunks +17 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h View 5 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp View 3 chunks +10 lines, -11 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaStream.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaStreamSource.h View 3 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebMediaStreamTrack.h View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
peria
PTL. This CL needs to be committed after https://codereview.chromium.org/1383803003/.
5 years, 2 months ago (2015-10-05 03:54:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384233002/1
5 years, 2 months ago (2015-10-05 03:54:38 UTC) #4
haraken
LGTM to try.
5 years, 2 months ago (2015-10-05 03:59:10 UTC) #5
tkent
Why don't you update user_media_client_impl_unittest.cc in this CL?
5 years, 2 months ago (2015-10-05 04:01:28 UTC) #7
haraken
On 2015/10/05 04:01:28, tkent wrote: > Why don't you update user_media_client_impl_unittest.cc in this CL? It ...
5 years, 2 months ago (2015-10-05 04:04:12 UTC) #8
peria
On 2015/10/05 04:01:28, tkent wrote: > Why don't you update user_media_client_impl_unittest.cc in this CL? I ...
5 years, 2 months ago (2015-10-05 04:08:01 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-05 05:35:39 UTC) #11
tkent
lgtm
5 years, 2 months ago (2015-10-06 01:19:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384233002/1
5 years, 2 months ago (2015-10-06 01:27:30 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 01:35:33 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 01:36:57 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05c95a5912f97f877aa75bbd55581778ba7044d6
Cr-Commit-Position: refs/heads/master@{#352507}

Powered by Google App Engine
This is Rietveld 408576698