Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 138423003: Change PluginWindowHandle type to be bool on Mac (Closed)

Created:
6 years, 11 months ago by ccameron
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Change PluginWindowHandle type to be bool on Mac. The change this was waiting on (removing windowed plugins) has been in effect for a long time. Also delete unused IPC messages. BUG=314190 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244967

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -23 lines) Patch
M content/child/plugin_messages.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/gfx/native_widget_types.h View 1 3 chunks +4 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ccameron
Small change (before bigger ones pulling in ui/ code to the Mac build)
6 years, 11 months ago (2014-01-15 02:32:29 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 11 months ago (2014-01-15 03:16:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/138423003/1
6 years, 11 months ago (2014-01-15 16:34:15 UTC) #3
ccameron
6 years, 11 months ago (2014-01-15 20:16:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r244967 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698