components/page_load_metrics/browser/metrics_web_contents_observer.h - Issue 1384213002: Page Abort Events for relevant navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.h

Issue 1384213002: Page Abort Events for relevant navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed tests + added a test Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/page_load_metrics/browser/metrics_web_contents_observer.h

diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.h b/components/page_load_metrics/browser/metrics_web_contents_observer.h

index cf39dc9bff6e66878fc7c4cdd5f3e4a02d02ff09..7e6818ced0a28af28df8374e15bfe447bb8c46e6 100644

--- a/components/page_load_metrics/browser/metrics_web_contents_observer.h

+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.h

@@ -52,6 +52,8 @@ enum PageLoadEvent {

PAGE_LOAD_SUCCESSFUL_FIRST_LAYOUT_FOREGROUND,

PAGE_LOAD_SUCCESSFUL_FIRST_LAYOUT_BACKGROUND,

+ PAGE_LOAD_ABORTED_BEFORE_FIRST_LAYOUT_RELEVANT,

Bryan McQuade 2015/10/05 17:46:00 can you add a comment for this one? what does rele

// Add values before this final count.

PAGE_LOAD_LAST_ENTRY

};

« no previous file with comments | « no previous file | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('j') | no next file with comments »