tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index cf6d33a699a0a7e4cf3bbd1b8bf2b6fd1f63b01e..19e2ccba255bfc47666376f0ae559421cbf55ce2 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -30024,6 +30024,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 <histogram name="PageLoad.EventCounts" enum="PageLoadEvent">
   <owner>csharrison@chromium.org</owner>
   <owner>bmcquade@chromium.org</owner>
+  <obsolete>
+    deprecated in favor of PageLoad.Events.*
+  </obsolete>
   <summary>
     Captures counts of various page load events. These are enumerated in the
     enum page_load_metrics::PageLoadEvent, and include events like 'page load
@@ -30031,6 +30034,37 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="PageLoad.Events.Committed" enum="CommittedLoadEvent">
+  <owner>csharrison@chromium.org</owner>
+  <owner>bmcquade@chromium.org</owner>
+  <summary>
+    Captures counts of load events post-commit, on relevant page loads (i.e.
+    http/https, not same-page, not an error page). These events include aborts
+    before first layout and successful first layouts. Note that the event
+    'Committed load started' when segmented by background/foreground specifies
+    whether the provisional load started in the background or foreground, not
+    the actual commit event. This is because we don't have all the data to
+    filter relevant page loads on provisional loads.
+  </summary>
+</histogram>
+
+<histogram name="PageLoad.Events.InternalError" enum="ErrorLoadEvent">
+  <owner>csharrison@chromium.org</owner>
+  <owner>bmcquade@chromium.org</owner>
+  <summary>
+    Counts of various internal error conditions in the page_load_metrics system.
+  </summary>
+</histogram>
+
+<histogram name="PageLoad.Events.Provisional" enum="ProvisionalLoadEvent">
+  <owner>csharrison@chromium.org</owner>
+  <owner>bmcquade@chromium.org</owner>
+  <summary>
+    Captures counts of provisional load events. These include aborted, failed,
+    and successful (committed) provisional loads.
+  </summary>
+</histogram>
+
 <histogram name="PageLoad.Timing.NavigationToDOMContentLoadedEventFired"
     units="milliseconds">
   <owner>bmcquade@chromium.org</owner>
@@ -30079,6 +30113,28 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="PageLoad.Timing2.NavigationToFirstBackground"
+    units="milliseconds">
+  <owner>bmcquade@chromium.org</owner>
+  <owner>csharrison@chromium.org</owner>
+  <summary>
+    Measures the time from navigation timing's navigation start to the time the
+    user first backgrounds the tab. Only measures navigations that started in
+    the foreground.
+  </summary>
+</histogram>
+
+<histogram name="PageLoad.Timing2.NavigationToFirstForeground"
+    units="milliseconds">
+  <owner>bmcquade@chromium.org</owner>
+  <owner>csharrison@chromium.org</owner>
+  <summary>
+    Measures the time from navigation timing's navigation start to the time the
+    user first foregrounds an initially backgrounded tab. Only measures
+    navigations that started in the background.
+  </summary>
+</histogram>
+
 <histogram name="PageLoad.Timing2.NavigationToFirstLayout" units="milliseconds">
   <owner>bmcquade@chromium.org</owner>
   <owner>csharrison@chromium.org</owner>
@@ -54241,6 +54297,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="505" label="505: HTTP Version Not Supported"/>
 </enum>
 
+<enum name="CommittedLoadEvent" type="int">
+  <int value="0" label="Committed load started"/>
+  <int value="1" label="Committed load failed before first layout"/>
+  <int value="2" label="Successful first layout"/>
+  <int value="3" label="Received a bad timing IPC"/>

[Bryan McQuade, 2015/10/15 03:47:36]

can remove this one (since it moved to the error enum)

[Charlie Harrison, 2015/10/15 14:06:48]

Good catch. Done.

+</enum>
+
 <enum name="CompositedScrolling" type="int">
   <int value="0" label="Is scrollable area"/>
   <int value="1" label="Needs to be stacking container"/>
@@ -56911,6 +56974,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="11004" label="WSANO_DATA"/>
 </enum>
 
+<enum name="ErrorLoadEvent" type="int">

[Bryan McQuade, 2015/10/15 03:47:36]

rename to InternalErrorLoadEvent

[Charlie Harrison, 2015/10/15 14:06:48]

Done.

+  <summary>Internal Errors in the page_load_metrics system</summary>
+  <int value="0" label="Invalid timing IPC sent from renderer"/>
+  <int value="1" label="IPC received while not tracking a committed load"/>
+  <int value="2" label="IPC received from a frame we navigated away from"/>
+  <int value="3" label="IPC received from a bad URL scheme"/>
+</enum>
+
 <enum name="ErrorPageButton" type="int">
   <int value="0" label="NO_BUTTON"/>
   <int value="1" label="RELOAD_BUTTON"/>
@@ -67141,6 +67212,10 @@ To add a new entry, add it with any value and run test to compute valid value.
   <int value="3" label="Aborted load before first layout"/>
   <int value="4" label="Successful first layout (foreground)"/>
   <int value="5" label="Successful first layout (backgrounded)"/>
+  <int value="6" label="Aborted load before first layout (relevant page load)"/>

[Bryan McQuade, 2015/10/15 03:47:36]

looks like these can be removed since we've abandoned the PageLoadEvent enum.
let's also add an <obsolete> tag to this enum.

[Charlie Harrison, 2015/10/15 14:06:48]

Done.

+  <int value="7" label="Relevant page load started in foreground"/>
+  <int value="8" label="Relevant page load started in backgound"/>
+  <int value="9" label="Received a bad timing IPC"/>
 </enum>
 
 <enum name="PageScaleFactorRange" type="int">
@@ -69244,6 +69319,12 @@ To add a new entry, add it with any value and run test to compute valid value.
   <int value="5" label="SPDY 4.0"/>
 </enum>
 
+<enum name="ProvisionalLoadEvent" type="int">
+  <int value="0" label="Provisional load aborted"/>

[Bryan McQuade, 2015/10/15 03:47:36]

let's add '(also includes downloads and 204s. crbug.com/542369)' so people using
the UMA dash are also aware of this.

[Charlie Harrison, 2015/10/15 14:06:48]

Done.

+  <int value="1" label="Provisional load failed with a non-abort"/>
+  <int value="2" label="Provisional load successfully committed"/>
+</enum>
+
 <enum name="ProvisionalSaveFailure" type="int">
   <int value="0" label="SAVING_DISABLED"/>
   <int value="1" label="EMPTY_PASSWORD"/>
@@ -78126,6 +78207,14 @@ To add a new entry, add it with any value and run test to compute valid value.
   <affected-histogram name="PageLoad.Timing2.NavigationToLoadEventFired"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="PageLoadBackgrounded2" separator=".">

[Bryan McQuade, 2015/10/15 03:47:36]

Can we use the existing 'BG' for these event cases as well?

[Charlie Harrison, 2015/10/15 14:06:48]

Same as other comment, per Randy.

+  <suffix name="Background"
+      label="Event occurred at least partially in the background. Replaces
+             PageLoadBackgrounded."/>
+  <affected-histogram name="PageLoad.Events.Committed"/>
+  <affected-histogram name="PageLoad.Events.Provisional"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="PageLoadType">
   <suffix name="HistoryLoad"
       label="but only for user pressing back or forward"/>