Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1384203002: Add imgblur tool to assist BlurMaskFilter debugging (Closed)

Created:
5 years, 2 months ago by robertphillips
Modified:
5 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add imgblur tool to assist BlurMaskFilter debugging imgblur is intended to establish a ground truth for debugging mask blur issues. It performs a brute force (non-separable) Gaussian blur of the provided image. The blur code itself is in sk_tools_utils so it can be more easily used programmatically in other places (e.g., blur unit tests). Committed: https://skia.googlesource.com/skia/+/9c4909b50ff9d0fdf9bce2a67cd459aeb28cdc3c

Patch Set 1 #

Patch Set 2 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -2 lines) Patch
M gyp/tools.gyp View 1 3 chunks +19 lines, -2 lines 0 comments Download
A tools/imgblur.cpp View 1 chunk +83 lines, -0 lines 0 comments Download
M tools/sk_tool_utils.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tools/sk_tool_utils.cpp View 1 1 chunk +94 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
robertphillips
5 years, 2 months ago (2015-10-04 18:06:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384203002/1
5 years, 2 months ago (2015-10-04 18:06:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-04 18:12:50 UTC) #6
reed1
How close are the results of the new code to what we ship (raster and ...
5 years, 2 months ago (2015-10-05 14:41:05 UTC) #7
robertphillips
With https://codereview.chromium.org/1378023004/ (Have GrRectBlurEffect use Linear filtering (rather than Nearest Neighbor)) the match is good ...
5 years, 2 months ago (2015-10-06 12:24:28 UTC) #8
reed1
lgtm
5 years, 2 months ago (2015-10-06 16:39:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384203002/1
5 years, 2 months ago (2015-10-07 12:09:54 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3511) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 2 months ago (2015-10-07 12:10:48 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384203002/20001
5 years, 2 months ago (2015-10-17 21:17:36 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-17 21:26:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384203002/20001
5 years, 2 months ago (2015-10-19 13:29:10 UTC) #20
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 13:39:20 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9c4909b50ff9d0fdf9bce2a67cd459aeb28cdc3c

Powered by Google App Engine
This is Rietveld 408576698