chrome/browser/notifications/notification_permission_infobar_delegate.cc - Issue 1384153003: Introduce a way to define Android-only IDR values that doesn't require

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_permission_infobar_delegate.cc

Issue 1384153003: Introduce a way to define Android-only IDR values that doesn't require (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: shortcircuit pointless lookup Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/protected_media_identifier_infobar_delegate.cc ('k') | chrome/browser/ui/android/infobars/confirm_infobar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_permission_infobar_delegate.cc

diff --git a/chrome/browser/notifications/notification_permission_infobar_delegate.cc b/chrome/browser/notifications/notification_permission_infobar_delegate.cc

index 532b39345398eb008531ba0c611d73eee5c28adf..105e48d81415d66c45a4ac43ba36a5d943b21c4c 100644

--- a/chrome/browser/notifications/notification_permission_infobar_delegate.cc

+++ b/chrome/browser/notifications/notification_permission_infobar_delegate.cc

@@ -4,11 +4,11 @@

#include "chrome/browser/notifications/notification_permission_infobar_delegate.h"

+#include "chrome/browser/android/android_theme_resources.h"

#include "chrome/browser/infobars/infobar_service.h"

#include "chrome/grit/generated_resources.h"

#include "components/infobars/core/infobar.h"

#include "components/url_formatter/elide_url.h"

-#include "grit/theme_resources.h"

#include "net/base/escape.h"

#include "ui/base/l10n/l10n_util.h"

@@ -39,7 +39,7 @@ NotificationPermissionInfobarDelegate::~NotificationPermissionInfobarDelegate()

{}

int NotificationPermissionInfobarDelegate::GetIconId() const {

- return IDR_INFOBAR_DESKTOP_NOTIFICATIONS;

+ return IDR_ANDROID_INFOBAR_NOTIFICATIONS;

}

base::string16 NotificationPermissionInfobarDelegate::GetMessageText() const {