Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 138413006: [GTK] Fix for muted tooltips while sound is playing. (Closed)

Created:
6 years, 11 months ago by miu
Modified:
6 years, 11 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Visibility:
Public.

Description

[GTK] Fix for muted tooltips while sound is playing. Tab media indicator data model updates indirectly cause TabGtk::UpdateTooltipState() to be invoked several times per second. This in turned resulted in calling gtk_widget_set_tooltip_text() redundantly. GTK responds to any tooltip text setter calls by hiding *all* tooltips throughout the application. The fix is to check whether the tooltip text actually is different, and not call the setter when the text is unchanged. In the bigger picture, there are other times when normal browser functionality would cause UpdateTooltipState() to be called several times per second. In general, the current implementation for handling tab data model updates is expensive and in bad need of rewriting. However, efforts would be better spent on moving Linux Chrome over to Aura. BUG=333002 TEST=Confirmed fixed using bug repro steps. R=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M chrome/browser/ui/gtk/tabs/tab_gtk.cc View 1 chunk +20 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
miu
erg: PTAL. This is intended to be a patch for M32 (yes, stable!) and M33.
6 years, 11 months ago (2014-01-15 23:15:08 UTC) #1
Elliot Glaysher
Ugly terrible no good hack LGTM!
6 years, 11 months ago (2014-01-15 23:17:42 UTC) #2
miu
On 2014/01/15 23:17:42, Elliot Glaysher wrote: > Ugly terrible no good hack LGTM! Heheh...Yeah, I ...
6 years, 11 months ago (2014-01-15 23:21:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/138413006/1
6 years, 11 months ago (2014-01-15 23:53:40 UTC) #4
miu
6 years, 11 months ago (2014-01-16 04:00:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r245103 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698