Description[GTK] Fix for muted tooltips while sound is playing.
Tab media indicator data model updates indirectly cause TabGtk::UpdateTooltipState() to be invoked several times per second. This in turned resulted in calling gtk_widget_set_tooltip_text() redundantly. GTK responds to any tooltip text setter calls by hiding *all* tooltips throughout the application.
The fix is to check whether the tooltip text actually is different, and not call the setter when the text is unchanged.
In the bigger picture, there are other times when normal browser functionality would cause UpdateTooltipState() to be called several times per second. In general, the current implementation for handling tab data model updates is expensive and in bad need of rewriting. However, efforts would be better spent on moving Linux Chrome over to Aura.
BUG=333002
TEST=Confirmed fixed using bug repro steps.
R=erg@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245103
Patch Set 1 #
Messages
Total messages: 5 (0 generated)
|