Issue 1384123002: Merge to XFA: Get rid of gotos in CPDF_SyntaxParser and FlateUncompress().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1384123002: Merge to XFA: Get rid of gotos in CPDF_SyntaxParser and FlateUncompress(). (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

Merge to XFA: Get rid of gotos in CPDF_SyntaxParser and FlateUncompress(). TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1360103002 . (cherry picked from commit b8a074711108baf04017d86207e08c19ff327d8e) Committed: https://pdfium.googlesource.com/pdfium/+/68bce6cfb69bfdfa9fc75f99d048cd7dbee79ff2

Patch Set 1 #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+322 lines, -334 lines)			Patch
M	core/include/fpdfapi/fpdf_parser.h	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	core/include/fxcrt/fx_basic.h	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View	26 chunks	+150 lines, -180 lines	1 comment	Download
M	core/src/fxcodec/codec/fx_codec_flate.cpp	View	11 chunks	+162 lines, -144 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

TBR https://codereview.chromium.org/1384123002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (left): https://codereview.chromium.org/1384123002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp#oldcode30 core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:30: static int32_t _CompareDWord(const void* p1, const void* p2) ...

5 years, 2 months ago (2015-10-02 20:30:22 UTC) #1

Lei Zhang

Committed patchset #1 (id:1) manually as 68bce6cfb69bfdfa9fc75f99d048cd7dbee79ff2 (presubmit successful).

5 years, 2 months ago (2015-10-02 20:30:30 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages