Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 13841011: Enable Native Client build of V8. (Closed)

Created:
7 years, 8 months ago by Brad Chen
Modified:
7 years, 8 months ago
Reviewers:
ulan, danno, Jakob Kummerow
CC:
v8-dev, Michael Starzinger
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Enable Native Client build of V8. These changes implement make targets nacl_ia32.check, nacl_x64.check, and related debug/release targets. BUG=2614 Committed: http://code.google.com/p/v8/source/detail?r=14299

Patch Set 1 #

Total comments: 4

Patch Set 2 : A few nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -4 lines) Patch
M Makefile View 1 9 chunks +42 lines, -3 lines 0 comments Download
M build/common.gypi View 2 chunks +9 lines, -1 line 0 comments Download
M src/globals.h View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Brad Chen
PTAL
7 years, 8 months ago (2013-04-09 16:11:28 UTC) #1
Brad Chen
With 13818012 landed, this is (hopefully) my last change. It should enable the Native Client ...
7 years, 8 months ago (2013-04-11 17:06:53 UTC) #2
Jakob Kummerow
LGTM with nits. https://codereview.chromium.org/13841011/diff/1/Makefile File Makefile (right): https://codereview.chromium.org/13841011/diff/1/Makefile#newcode275 Makefile:275: tools/run-tests.py $(TESTJOBS) --outdir=$(OUTDIR)/native \ accidental edit? ...
7 years, 8 months ago (2013-04-12 09:13:32 UTC) #3
Brad Chen
PTAL New patch uploaded. I will need your help to submit. Thanks, Brad https://codereview.chromium.org/13841011/diff/1/Makefile File ...
7 years, 8 months ago (2013-04-12 18:37:00 UTC) #4
Jakob Kummerow
LGTM, landing.
7 years, 8 months ago (2013-04-17 08:25:10 UTC) #5
Jakob Kummerow
7 years, 8 months ago (2013-04-17 08:27:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r14299 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698