Issue 13841003: Separate Math Lithium operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13841003: Separate Math Lithium operations. (Closed)

Created:
7 years, 8 months ago by Sven Panne

Modified:
7 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Separate Math Lithium operations. This makes the logic in the Hydrogen->Lithium translation much clearer, avoids a hand-written dispatch and even opened up opportunities for simpler register constraints for some operations/platforms. Doing the same for the Hydrogen level might be done in a follow-up CL. Committed: http://code.google.com/p/v8/source/detail?r=14233

Patch Set 1 #

Patch Set 2 : MIPS #

Patch Set 3 : separate Lithium instructions on ia32 #

Patch Set 4 : separate Lithium instructions on x64 #

Patch Set 5 : separate Lithium instructions on ARM #

Patch Set 6 : Support on all platforms #

Patch Set 7 : Rebased #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+895 lines, -502 lines)			Patch
M	src/arm/lithium-arm.h	View	1 2 3 4 5	7 chunks	+122 lines, -8 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 2 3 4	2 chunks	+91 lines, -48 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.h	View	1 2 3 4	2 chunks	+2 lines, -12 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2 3 4 5	11 chunks	+13 lines, -50 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	1 2	2 chunks	+2 lines, -10 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2 3 4 5 6	10 chunks	+11 lines, -42 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1 2 3 4 5	7 chunks	+105 lines, -24 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 2 3 4 5	2 chunks	+95 lines, -75 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.h	View	1 2 3 4 5	2 chunks	+2 lines, -12 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 2 3 4 5	12 chunks	+13 lines, -50 lines	0 comments	Download
M	src/mips/lithium-mips.h	View	1 2 3 4 5	7 chunks	+124 lines, -8 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 2 3 4 5	2 chunks	+93 lines, -51 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View	1 2 3	2 chunks	+2 lines, -12 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2 3 4 5 6	11 chunks	+13 lines, -50 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	1 2 3 4 5	6 chunks	+120 lines, -8 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 2 3 4	2 chunks	+87 lines, -42 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

7 years, 8 months ago (2013-04-11 13:27:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #7 manually as r14233 (presubmit successful).

Expand Messages | Collapse Messages