Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1384063002: Fix build breaks on iOS. Adds missing import and avoid use of unavailable macro. (Closed)

Created:
5 years, 2 months ago by Chinmay
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, abarth, Cutch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix build breaks on iOS. Adds missing import and avoid use of unavailable macro. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/8a2d122e1a7bb1fb31ca29054165c440c5d50e1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M runtime/vm/os_macos.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Chinmay
5 years, 2 months ago (2015-10-02 17:57:10 UTC) #2
abarth-chromium
You'll probably want a reviewer who works on the DartVM.
5 years, 2 months ago (2015-10-02 17:59:07 UTC) #4
rmacnak
lgtm cc John
5 years, 2 months ago (2015-10-02 18:11:43 UTC) #6
Chinmay
5 years, 2 months ago (2015-10-02 18:14:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a2d122e1a7bb1fb31ca29054165c440c5d50e1c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698