Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: sdk/lib/_internal/js_runtime/lib/async_patch.dart

Issue 1383983002: Make root-zone handleUncaughtError rethrow with the correct stack. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/js_runtime/lib/async_patch.dart
diff --git a/sdk/lib/_internal/js_runtime/lib/async_patch.dart b/sdk/lib/_internal/js_runtime/lib/async_patch.dart
index f8412c1be549a41d274ab123fa242ab478cfbc9d..1155e79f76964886ed61ab0c2006b9ed1c5e292f 100644
--- a/sdk/lib/_internal/js_runtime/lib/async_patch.dart
+++ b/sdk/lib/_internal/js_runtime/lib/async_patch.dart
@@ -506,3 +506,8 @@ class _SyncStarIterable extends IterableBase {
Iterator get iterator => new _SyncStarIterator(JS('', '#()', _outerHelper));
}
+
+@patch
+void _rethrow(Object error, StackTrace stackTrace) {
+ throw new AsyncError(error, stackTrace);
Ivan Posva 2015/10/02 23:40:39 This seems to differ significantly from the VM imp
Lasse Reichstein Nielsen 2015/10/05 06:18:49 I haven't found a way to throw an object *and* a s
+}

Powered by Google App Engine
This is Rietveld 408576698