Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: runtime/lib/async_patch.dart

Issue 1383983002: Make root-zone handleUncaughtError rethrow with the correct stack. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/lib/errors.cc » ('j') | sdk/lib/_internal/js_runtime/lib/async_patch.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import "dart:_internal"; 5 import "dart:_internal";
6 6
7 // We need to pass the value as first argument and leave the second and third 7 // We need to pass the value as first argument and leave the second and third
8 // arguments empty (used for error handling). 8 // arguments empty (used for error handling).
9 // See vm/ast_transformer.cc for usage. 9 // See vm/ast_transformer.cc for usage.
10 Function _asyncThenWrapperHelper(continuation) { 10 Function _asyncThenWrapperHelper(continuation) {
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 if (controller.isClosed) { 175 if (controller.isClosed) {
176 return null; 176 return null;
177 } 177 }
178 if (cancellationCompleter == null) { 178 if (cancellationCompleter == null) {
179 cancellationCompleter = new Completer(); 179 cancellationCompleter = new Completer();
180 scheduleGenerator(); 180 scheduleGenerator();
181 } 181 }
182 return cancellationCompleter.future; 182 return cancellationCompleter.future;
183 } 183 }
184 } 184 }
185
186 patch void _rethrow(Object error, StackTrace stackTrace) native "Zone_rethrow";
Ivan Posva 2015/10/02 23:40:39 Strictly speaking this native should be named "Asy
Lasse Reichstein Nielsen 2015/10/05 06:18:49 Renamed to Async_rethrow. It's top-level because i
OLDNEW
« no previous file with comments | « no previous file | runtime/lib/errors.cc » ('j') | sdk/lib/_internal/js_runtime/lib/async_patch.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698