XFA: Remove checks for new returning NULL in fpdfsdk.

fpdfsdk/src/fpdfview.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../core/include/fpdfapi/fpdf_module.h"
 #include "../../core/include/fxcodec/fx_codec.h"
 #include "../../core/include/fxcrt/fx_safe_types.h"
 #include "../../public/fpdf_ext.h"
@@ skipping 247 matching lines @@
   if (err_code) {
     delete pParser;
     ProcessParseError(err_code);
     return NULL;
   }
   CPDF_Document* pPDFDoc = pParser->GetDocument();
   if (!pPDFDoc)
     return NULL;
 
   CPDFXFA_App* pProvider = CPDFXFA_App::GetInstance();
-  CPDFXFA_Document* pDocument = new CPDFXFA_Document(pPDFDoc, pProvider);
-  return pDocument;
+  return new CPDFXFA_Document(pPDFDoc, pProvider);
 }
 
 DLLEXPORT FPDF_BOOL STDCALL FPDF_HasXFAField(FPDF_DOCUMENT document,
                                              int* docType) {
   if (!document)
     return FALSE;
 
   CPDF_Document* pdfDoc =
       (static_cast<CPDFXFA_Document*>(document))->GetPDFDoc();
   if (!pdfDoc)
@@ skipping 64 matching lines @@
     return NULL;
   }
   CPDF_Document* pDoc = NULL;
   pDoc = pParser ? pParser->GetDocument() : NULL;
   CheckUnSupportError(pDoc, err_code);
   CPDF_Document* pPDFDoc = pParser->GetDocument();
   if (!pPDFDoc)
     return NULL;
 
   CPDFXFA_App* pProvider = CPDFXFA_App::GetInstance();
-  CPDFXFA_Document* pDocument = new CPDFXFA_Document(pPDFDoc, pProvider);
-  return pDocument;
+  return new CPDFXFA_Document(pPDFDoc, pProvider);
 }
 
 DLLEXPORT FPDF_DOCUMENT STDCALL
 FPDF_LoadCustomDocument(FPDF_FILEACCESS* pFileAccess,
                         FPDF_BYTESTRING password) {
   CPDF_Parser* pParser = new CPDF_Parser;
   pParser->SetPassword(password);
   CPDF_CustomAccess* pFile = new CPDF_CustomAccess(pFileAccess);
   FX_DWORD err_code = pParser->StartParse(pFile);
   if (err_code) {
     delete pParser;
     ProcessParseError(err_code);
     return NULL;
   }
   CPDF_Document* pDoc = NULL;
   pDoc = pParser ? pParser->GetDocument() : NULL;
   CheckUnSupportError(pDoc, err_code);
   CPDF_Document* pPDFDoc = pParser->GetDocument();
   if (!pPDFDoc)
     return NULL;
 
   CPDFXFA_App* pProvider = CPDFXFA_App::GetInstance();
-  CPDFXFA_Document* pDocument = new CPDFXFA_Document(pPDFDoc, pProvider);
-  return pDocument;
+  return new CPDFXFA_Document(pPDFDoc, pProvider);
 }
 
 DLLEXPORT FPDF_BOOL STDCALL FPDF_GetFileVersion(FPDF_DOCUMENT doc,
                                                 int* fileVersion) {
   if (!doc || !fileVersion)
     return FALSE;
   *fileVersion = 0;
   CPDFXFA_Document* pDoc = (CPDFXFA_Document*)doc;
   CPDF_Document* pPDFDoc = pDoc->GetPDFDoc();
   if (!pPDFDoc)
@@ skipping 488 matching lines @@
     pContext->m_pDevice->RestoreState();
   }
 
   //#endif
 }
 
 DLLEXPORT int STDCALL FPDF_GetPageSizeByIndex(FPDF_DOCUMENT document,
                                               int page_index,
                                               double* width,
                                               double* height) {
-  //    CPDF_Document* pDoc = (CPDF_Document*)document;
-  //    if(pDoc == NULL)
-  //            return FALSE;
-  //
-  //    CPDF_Dictionary* pDict = pDoc->GetPage(page_index);
-  //    if (pDict == NULL) return FALSE;
-  //
-  //    CPDF_Page page;
-  //    page.Load(pDoc, pDict);
-  //    *width = page.GetPageWidth();
-  //    *height = page.GetPageHeight();
-
   CPDFXFA_Document* pDoc = (CPDFXFA_Document*)document;
   if (pDoc == NULL)
     return FALSE;
 
   int count = pDoc->GetPageCount();
   if (page_index < 0 || page_index >= count)
     return FALSE;
 
   CPDFXFA_Page* pPage = pDoc->GetPage(page_index);
   if (!pPage)
@@ skipping 187 matching lines @@
   if (!buffer) {
     *buflen = len;
   } else if (*buflen >= len) {
     memcpy(buffer, utf16Name.c_str(), len);
     *buflen = len;
   } else {
     *buflen = -1;
   }
   return (FPDF_DEST)pDestObj;
 }