Issue 1383903002: wrap_jso should wrap JsArray as well, not always call wrap on its contents

Issue 1383903002: wrap_jso should wrap JsArray as well, not always call wrap on its contents (Closed)

Created:
5 years, 2 months ago by Alan Knight

Modified:
5 years, 2 months ago

Reviewers:
terry, Jacob

CC:
reviews_dartlang.org, ricow1

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -17 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View	1 2	8 chunks	+29 lines, -7 lines	0 comments	Download
M	sdk/lib/js/dartium/js_dartium.dart	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	sdk/lib/web_sql/dartium/web_sql_dartium.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/html.status	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
A	tests/html/wrapping_collections_test.dart	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View		2 chunks	+22 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_MutationObserver.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

Alan Knight

Committed patchset #2 (id:20001) manually as f0e52e4e9175c10739645b6a1f72d551f6b9fd06 (presubmit successful).

5 years, 2 months ago (2015-10-01 23:22:21 UTC) #3

Alan Knight

Fixed to also add List types to the things that need wrapping in generator.py. Try ...

5 years, 2 months ago (2015-10-02 19:48:00 UTC) #4

Alan Knight

Committed patchset #3 (id:40001) manually as 110b579b8ac04510a2852964db54bbd9f2f59c87 (presubmit successful).

5 years, 2 months ago (2015-10-02 19:48:12 UTC) #5

Message was sent while issue was closed.

lgtm