net/data/parse_certificate_unittest/extension_critical_0.pem - Issue 1383873002: Add a function for parsing an RFC 5280 Extension.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/parse_certificate_unittest/extension_critical_0.pem

Issue 1383873002: Add a function for parsing an RFC 5280 Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 This is a basic constraints extension, where the critical field (BOOLEAN) is 0.

	2

	3 This is not valid because the critical field has a default of FALSE, so under

	4 DER-encoding it should be omitted.

	5

	6

	7 $ openssl asn1parse -i < [EXTENSION]

	8 0:d=0 hl=2 l= 12 cons: SEQUENCE

	9 2:d=1 hl=2 l= 3 prim: OBJECT :X509v3 Basic Constraints

	10 7:d=1 hl=2 l= 1 prim: BOOLEAN :0

	11 10:d=1 hl=2 l= 2 prim: OCTET STRING [HEX DUMP]:3000

	12

	13 -----BEGIN EXTENSION-----

	14 MAwGA1UdEwEBAAQCMAA=

	15 -----END EXTENSION-----

OLD	NEW