Issue 138383002: MIPS: Make the strict-mode calling convention for contextual calls the default one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138383002: MIPS: Make the strict-mode calling convention for contextual calls the default one. (Closed)

Created:
6 years, 11 months ago by kilvadyb

Modified:
6 years, 11 months ago

Reviewers:
Paul Lind, danno, kisg, palfia, Toon Verwaest, dusmil

CC:
v8-dev

Base URL:
https://github.com/v8/v8.git@gbl

Visibility:
Public.

More Reviews

Description

MIPS: Make the strict-mode calling convention for contextual calls the default one. Port r18581 (e5df8ae) BUG=

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -114 lines)			Patch
M	src/mips/builtins-mips.cc	View	5 chunks	+6 lines, -9 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	3 chunks	+4 lines, -49 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	5 chunks	+18 lines, -13 lines	1 comment	Download
M	src/mips/ic-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	6 chunks	+26 lines, -16 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	3 chunks	+4 lines, -24 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

LGTM, I'll fix the nit when committing it. https://codereview.chromium.org/138383002/diff/1/src/mips/full-codegen-mips.cc File src/mips/full-codegen-mips.cc (right): https://codereview.chromium.org/138383002/diff/1/src/mips/full-codegen-mips.cc#newcode2863 src/mips/full-codegen-mips.cc:2863: __ ...

6 years, 11 months ago (2014-01-14 16:21:36 UTC) #2

Committed as r18596.

Expand Messages | Collapse Messages