Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1383803003: content/renderer/media: Use collectAllGarbageForTesting in tests (Closed)

Created:
5 years, 2 months ago by peria
Modified:
5 years, 2 months ago
Reviewers:
haraken, mcasas
CC:
chromium-reviews, asanka, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, benjhayden+dwatch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use WebHeap::collectAllGarbageForTesting instead of WebHeap::collectGarbageForTesting. Background: Blink memory team is shipping a mark-and-sweep GC (Oilpan) to media stream classes, and those classes have many references between Chromium and Blink. If a reference chain has multiple references between Chromium and Blink, collectGarbageForTesting collects one of them. Instead, collectAllGarageForTesting is expected to collect all references. BUG=None Committed: https://crrev.com/ed516c60b6cac51ef3d7a1e39c9e063daf14d787 Cr-Commit-Position: refs/heads/master@{#352471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M content/renderer/media/user_media_client_impl_unittest.cc View 5 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
peria
PTL
5 years, 2 months ago (2015-10-05 02:32:28 UTC) #2
haraken
LGTM
5 years, 2 months ago (2015-10-05 02:32:53 UTC) #3
mcasas
lgtm
5 years, 2 months ago (2015-10-05 15:54:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383803003/1
5 years, 2 months ago (2015-10-05 23:26:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 00:05:50 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 00:06:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed516c60b6cac51ef3d7a1e39c9e063daf14d787
Cr-Commit-Position: refs/heads/master@{#352471}

Powered by Google App Engine
This is Rietveld 408576698