Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1383783003: Roll PDFium revision to 3dedace and use the new init API. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll PDFium revision to 3dedace and use the new init API. Also pick up another bug fix in the DEPS roll. https://pdfium.googlesource.com/pdfium.git/+log/b8a0747..3dedace BUG=531339, 537173 Committed: https://crrev.com/b331e81dd0357eb0c483cfac3e3fe2a594fe54ef Cr-Commit-Position: refs/heads/master@{#352254}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 3 chunks +7 lines, -4 lines 2 comments Download

Messages

Total messages: 10 (2 generated)
Lei Zhang
5 years, 2 months ago (2015-10-03 00:05:27 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1383783003/diff/1/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/1383783003/diff/1/pdf/pdfium/pdfium_engine.cc#newcode597 pdf/pdfium/pdfium_engine.cc:597: config.m_pIsolate = v8::Isolate::GetCurrent(); What do we give up ...
5 years, 2 months ago (2015-10-03 01:07:13 UTC) #3
Tom Sepez
lgtm lgtm
5 years, 2 months ago (2015-10-03 01:07:15 UTC) #4
Lei Zhang
https://codereview.chromium.org/1383783003/diff/1/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/1383783003/diff/1/pdf/pdfium/pdfium_engine.cc#newcode597 pdf/pdfium/pdfium_engine.cc:597: config.m_pIsolate = v8::Isolate::GetCurrent(); On 2015/10/03 01:07:13, Tom Sepez wrote: ...
5 years, 2 months ago (2015-10-03 01:09:05 UTC) #5
Lei Zhang
I have other issues with reproducing the bug in a debug build, but I can ...
5 years, 2 months ago (2015-10-03 02:36:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383783003/1
5 years, 2 months ago (2015-10-03 08:10:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-03 12:10:08 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-03 12:11:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b331e81dd0357eb0c483cfac3e3fe2a594fe54ef
Cr-Commit-Position: refs/heads/master@{#352254}

Powered by Google App Engine
This is Rietveld 408576698