Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1383773003: Preserve identity on JsObject wrappers (Closed)

Created:
5 years, 2 months ago by Alan Knight
Modified:
5 years, 2 months ago
Reviewers:
terry, Jacob
CC:
reviews+dom_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Preserve identity on JsObject wrappers BUG= Committed: https://src.chromium.org/viewvc/blink/branches/dart/dartium?view=rev&revision=202672

Patch Set 1 #

Patch Set 2 : Whitespace cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M Source/bindings/core/dart/DartJsInterop.cpp View 1 1 chunk +37 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Alan Knight
TBR
5 years, 2 months ago (2015-10-01 17:06:17 UTC) #2
Alan Knight
Committed patchset #2 (id:20001) manually as 202672 (tree was closed).
5 years, 2 months ago (2015-10-01 17:07:25 UTC) #3
Jacob
5 years, 2 months ago (2015-10-01 20:53:01 UTC) #4
Message was sent while issue was closed. 
Wow that is beautiful code.
lgtm

Powered by Google App Engine
This is Rietveld 408576698