Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: src/gpu/gl/GrGLAssembleInterface.cpp

Issue 1383763004: Add work around for devices/API filters that claim GL_KHR_debug support but don't provide functions (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: ! Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright 2014 Google Inc. 3 * Copyright 2014 Google Inc.
4 * 4 *
5 * Use of this source code is governed by a BSD-style license that can be 5 * Use of this source code is governed by a BSD-style license that can be
6 * found in the LICENSE file. 6 * found in the LICENSE file.
7 */ 7 */
8 8
9 9
10 #include "GrGLAssembleInterface.h" 10 #include "GrGLAssembleInterface.h"
(...skipping 737 matching lines...) Expand 10 before | Expand all | Expand 10 after
748 } 748 }
749 749
750 if (extensions.has("GL_KHR_debug")) { 750 if (extensions.has("GL_KHR_debug")) {
751 GET_PROC_SUFFIX(DebugMessageControl, KHR); 751 GET_PROC_SUFFIX(DebugMessageControl, KHR);
752 GET_PROC_SUFFIX(DebugMessageInsert, KHR); 752 GET_PROC_SUFFIX(DebugMessageInsert, KHR);
753 GET_PROC_SUFFIX(DebugMessageCallback, KHR); 753 GET_PROC_SUFFIX(DebugMessageCallback, KHR);
754 GET_PROC_SUFFIX(GetDebugMessageLog, KHR); 754 GET_PROC_SUFFIX(GetDebugMessageLog, KHR);
755 GET_PROC_SUFFIX(PushDebugGroup, KHR); 755 GET_PROC_SUFFIX(PushDebugGroup, KHR);
756 GET_PROC_SUFFIX(PopDebugGroup, KHR); 756 GET_PROC_SUFFIX(PopDebugGroup, KHR);
757 GET_PROC_SUFFIX(ObjectLabel, KHR); 757 GET_PROC_SUFFIX(ObjectLabel, KHR);
758 // In general we have a policy against removing extension strings when t he driver does
759 // not provide function pointers for an advertised extension. However, b ecause there is a
760 // known device that advertises GL_KHR_debug but fails to provide the fu nctions and this is
761 // a debugging- only extension we've made an exception. This also can ha ppen when using
762 // APITRACE.
763 if (!interface->fFunctions.fDebugMessageControl) {
764 extensions.remove("GL_KHR_debug");
765 }
758 } 766 }
759 767
760 interface->fStandard = kGLES_GrGLStandard; 768 interface->fStandard = kGLES_GrGLStandard;
761 interface->fExtensions.swap(&extensions); 769 interface->fExtensions.swap(&extensions);
762 770
763 return interface; 771 return interface;
764 } 772 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698