Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1383743002: Automatically add extra CQ trybots for predetermined paths (Closed)

Created:
5 years, 2 months ago by rmistry
Modified:
5 years, 2 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Automatically add extra CQ trybots for predetermined paths If the CL does not contain a "CQ_EXTRA_TRYBOTS=" section then it constructs one from the paths modified in your CL. If you already have an existing "CQ_EXTRA_TRYBOTS=" section in your CL then it parses it, preserves your options, and only adds the builders and masters that were missing. Also ensures no trybots are repeated (i.e. each master trybot combination only shows up once). And I killed the hashtags feature in this CL, nobody was using it. BUG=skia:4364 Committed: https://skia.googlesource.com/skia/+/5827653e4271e6f33d2dbd6ac088a6de80fbcea7

Patch Set 1 : Initial upload #

Patch Set 2 : Cleanup #

Patch Set 3 : More cleanup #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -76 lines) Patch
D HASHTAGS View 1 1 chunk +0 lines, -22 lines 0 comments Download
M PRESUBMIT.py View 1 2 3 6 chunks +74 lines, -54 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rmistry
5 years, 2 months ago (2015-10-01 14:53:18 UTC) #2
mtklein
lgtm
5 years, 2 months ago (2015-10-01 15:09:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383743002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383743002/60001
5 years, 2 months ago (2015-10-01 15:17:30 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 15:24:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/5827653e4271e6f33d2dbd6ac088a6de80fbcea7

Powered by Google App Engine
This is Rietveld 408576698